Add Waveshare RP2040-GEEK + ESP32-S3-GEEK feature #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvprat
reviewed
Apr 1, 2024
| family: raspberrypi | ||
| features: | ||
| - USB-C | ||
| - Wi-Fi |
There was a problem hiding this comment.
Is this correct? The RP2040 doesn't have WiFi, is it provided externally?
jvprat
reviewed
Apr 1, 2024
| date_added: 2024-03-29 | ||
| family: raspberrypi | ||
| features: | ||
| - USB-C |
There was a problem hiding this comment.
AFAIK none of these boards (esp32s3 and rp2040) have USB-C
Contributor
Author
There was a problem hiding this comment.
Ugh, I don't know where my head was, good catch, I'll submit a new PR to drop the RP2040 WiFi and remove USB-C from both the RP2040 and S3 Geek modules.
Thanks!
There was a problem hiding this comment.
Thank you for adding support for the boards! ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add newly merged board adafruit/circuitpython#9090 (review)
Also updated the Waveshare ESP32-S3-GEEK page to include the Display feature.