Allow microcontroller.nvm to be bigger than 64k #10720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR allows NVM to be bigger than 64kBytes.
Bug
Assume
mpconfigboard.hspecifies:#define CIRCUITPY_INTERNAL_NVM_SIZE (136*1024).But
len(microcontroller.nvm)will return 8192 as theuint16_twraps.With this PR applied,
len(microcontroller.nvm)will return 139264 which is, as expected, 136*1024.Test
I tested this PR on a nordic pca10059 using
#define CIRCUITPY_INTERNAL_NVM_SIZE (136*1024).