Adding SparkFun nRF52840 Mini board support #1367
Conversation
|
|
||
| STATIC const mp_rom_map_elem_t board_module_globals_table[] = { | ||
| { MP_ROM_QSTR(MP_QSTR_P0_00), MP_ROM_PTR(&pin_P0_00) }, | ||
| { MP_ROM_QSTR(MP_QSTR_P0_01), MP_ROM_PTR(&pin_P0_01) }, |
There was a problem hiding this comment.
No need to add the internal nRF names here. They are available through microcontroller.pin automatically. This table should just include names to match a board's silkscreen and other common designations (like SDA and SCL). Limiting whats in here makes dir(BOARD) easier to understand.
There was a problem hiding this comment.
Sweet. More than happy to delete some stuff in here!
| { MP_ROM_QSTR(MP_QSTR_P1_14), MP_ROM_PTR(&pin_P1_14) }, | ||
| { MP_ROM_QSTR(MP_QSTR_P1_15), MP_ROM_PTR(&pin_P1_15) }, | ||
|
|
||
| { MP_ROM_QSTR(MP_QSTR_UART), MP_ROM_PTR(&board_uart_obj) }, |
There was a problem hiding this comment.
Do you want I2C and SPI default buses here too?
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
I can't tell you how excited I am to see this! I just ordered a board for myself plus a few of the SparkFun SAMD boards.
A couple minor things but then we'll get it in.
I'm currently fixing up the build because Nordic changed how to download the soft device. So, we can ignore Travis for a bit once the other comments are addressed.
|
Thanks @tannewt! Revised pins.c to only define pins that are available to the user. And reorganized the file a bit. (Oof...great timing with Nordic's re-organizing. I haven't been able to test from scratch with their updates yet.) |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
I just remembered that you'll want to add your board to the first TRAVIS_BOARDS variable here: https://github.com/adafruit/circuitpython/blob/master/.travis.yml#L24 That way the latest will always be built and released.
| { MP_ROM_QSTR(MP_QSTR_P1_14), MP_ROM_PTR(&pin_P1_14) }, | ||
| { MP_ROM_QSTR(MP_QSTR_P1_15), MP_ROM_PTR(&pin_P1_15) }, | ||
|
|
||
| { MP_ROM_QSTR(MP_QSTR_UART), MP_ROM_PTR(&board_uart_obj) }, |
|
@jimblom Want me to finish the polish on this and merge? |
|
@jimblom I've pushed the fixes to your branch and will merge after Travis is happy. |
2 participants
Pin/board-definitions and documentation to support the SparkFun Pro nRF52840 Mini .
Tested with
make BOARD=sparkfun_nrf52840_miniin the ports/nrf directory.We're working on building up some documentation here.