-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added support for MKRZero and Created Board Test Suite #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tannewt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thank you for this. I changed my mind on where the board test stuff should go because libraries are auto-converted to mpy on release and the readmes are easier to find. Please PR the test files to here instead: https://github.com/adafruit/Adafruit_CircuitPython_BoardTest
That should simplify this PR a bunch.
Also, please add the board name to one of the lists at the top of .travis.yml so that its auto built and auto-released.
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| - `Electronic Cats Meow Meow <https://electroniccats.com/gomeow/>`__ | ||
| - `Electronic Cats CatWAN USB Stick <https://electroniccats.com/producto/catwan_usb_stick/>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing __ is needed for RST links here and above. You can see the output on GitHub by clicking View File: https://github.com/adafruit/circuitpython/blob/f8ded46ad69ebba2de5b791bde16c50c4d2b1d1b/README.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. I'll cancel the PR and re-submit with the test code in the other repo. Thanks!
|
This error happened in the doc build in travis, I think because the link is a redirect (redirects to |
|
Thanks for catching that. I'm new to Travis and RST, so this is all learning for me :) |
|
Closing PR. Will submit MKRZero port separately and move test suite to different repo as per @tannewt 's request. |
Arduino MKRZero pins and board definitions added for ports/atmel-samd/boards. Created a set of tests for similar ports. These tests can be run individually to ensure that pins and buses work properly when creating a new port.