Skip to content

added height and width attributes for displayio #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhalbert merged 3 commits into from
Mar 6, 2019
Merged

added height and width attributes for displayio #1601

dhalbert merged 3 commits into from
Mar 6, 2019

Conversation

@GiantRobato
Copy link

@GiantRobato GiantRobato commented Feb 26, 2019 •
edited
Loading

Tested with the following:

import time
import board
import displayio

print(board.DISPLAY.width())
print(board.DISPLAY.height())

relates to #1588

siddacious
siddacious suggested changes Feb 26, 2019
View reviewed changes
@siddacious
Copy link

siddacious commented Feb 26, 2019

It also looks like Travis failed due to reasons beyond your/my control. @dhalbert any ideas?

@GiantRobato
Copy link
Author

GiantRobato commented Feb 26, 2019

@siddacious thanks for the references! I couldn't figure out what the correct type i needed in order to make it show as a property. I don't have the board I was working on anymore (just finished with the pycascades sprint) but I have a pyportal coming in the mail soon so I can update with the requested changes.

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 26, 2019

The Travis issues are https://git.savannah.gnu.org/ being flaky, which is relatively common. I'll restart those jobs.

@siddacious
Copy link

siddacious commented Mar 2, 2019

Looks great!

Adafruit CircuitPython 4.0.0-beta.2-174-g0ac40235b-dirty on 2019-03-02; Adafruit PyPortal with samd51j20
>>> import board
>>> board.DISPLAY.height
240
>>> board.DISPLAY.width
320

siddacious
siddacious previously approved these changes Mar 2, 2019
View reviewed changes
@siddacious
Copy link

siddacious commented Mar 2, 2019

Someone else will have to merge but this looks good to go. @dhalbert?

dhalbert
dhalbert requested changes Mar 3, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the uint16_t stuff. Looks good!

shared-bindings/displayio/Display.h Outdated
bool common_hal_displayio_display_get_auto_brightness(displayio_display_obj_t* self);
void common_hal_displayio_display_set_auto_brightness(displayio_display_obj_t* self, bool auto_brightness);

mp_int_t common_hal_displayio_display_get_width(displayio_display_obj_t* self);
Copy link
Collaborator

@dhalbert dhalbert Mar 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use uint16_t here instead of mp_int_t, because that's the type of width and height that are passed in.

@dhalbert
Copy link
Collaborator

dhalbert commented Mar 6, 2019

Great, thanks!

@dhalbert dhalbert merged commit 2eaa98a into adafruit:master Mar 6, 2019
@dhalbert dhalbert mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert dhalbert approved these changes

+1 more reviewer

@siddacious siddacious siddacious left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiantRobato @siddacious @dhalbert