Skip to content

Added option to enable toggling CS between init commands #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannewt merged 11 commits into from
Mar 28, 2019
Merged

Added option to enable toggling CS between init commands #1685

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fadb5a1
Added option to toggle cs in displayio init sequence
Mar 24, 2019
2bb63cb
Added new parameter description in displayio RTD comment
Mar 24, 2019
d2a0ec2
Fixed display init on boards with displays
Mar 24, 2019
0c33f7f
Enable CS toggle for displayio by default
Mar 24, 2019
b25c4ba
Moving Toggle to before command fixes driver issue
Mar 24, 2019
d9de1b9
Updated RTD comment to reflect new param defaulting True
Mar 24, 2019
09a1f06
Added small delay inside toggle for edge cases
Mar 26, 2019
0df4053
Merge branch 'master' of https://github.com/adafruit/circuitpython
Mar 27, 2019
b2ad16f
Removed parameter so CS is always toggled
Mar 27, 2019
2f7b338
Comment Cleanup
Mar 27, 2019
f3ec051
Simplified into fourwire only
Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shared-module/displayio/FourWire.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

#include "shared-bindings/busio/SPI.h"
#include "shared-bindings/digitalio/DigitalInOut.h"
#include "shared-bindings/time/__init__.h"

#include "tick.h"

Expand Down Expand Up @@ -78,6 +79,11 @@ bool common_hal_displayio_fourwire_begin_transaction(mp_obj_t obj) {

void common_hal_displayio_fourwire_send(mp_obj_t obj, bool command, uint8_t *data, uint32_t data_length) {
displayio_fourwire_obj_t* self = MP_OBJ_TO_PTR(obj);
if (command) {
common_hal_digitalio_digitalinout_set_value(&self->chip_select, true);
common_hal_time_delay_ms(1);
common_hal_digitalio_digitalinout_set_value(&self->chip_select, false);
}
common_hal_digitalio_digitalinout_set_value(&self->command, !command);
common_hal_busio_spi_write(self->bus, data, data_length);
}
Expand Down