Skip to content

Conversation

@ntavish
Copy link

@ntavish ntavish commented May 23, 2019

Signed-off-by: Tavish Naruka tavishnaruka@gmail.com

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Add it to .travis.yml TRAVIS_TESTS variable, like your other board.

@dhalbert dhalbert self-requested a review May 28, 2019 13:36
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[meant to Request Changes]

Looks good. Add it to .travis.yml TRAVIS_TESTS variable, like your other board.

@tannewt
Copy link
Member

tannewt commented Jun 4, 2019

@ntavish Sorry this has taken a while. Would you mind reopening a PR on the 4.0.x branch so that it gets released with the next stable release? We'll then merge 4.0.x back into master. master will be released as unstable next.

@ntavish ntavish changed the base branch from master to 4.0.x June 4, 2019 19:16
Signed-off-by: Tavish Naruka <tavishnaruka@gmail.com>
@ntavish
Copy link
Author

ntavish commented Jun 4, 2019

@tannewt Hi, no problem. I modified this PR to do that. Hope that's fine also.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too! Thank you!

@tannewt tannewt merged commit c90ce2b into adafruit:4.0.x Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants