Implement and use RUN_BACKGROUND_TASKS in place of MICROPY_VM_HOOK_LOOP #2055
Conversation
.. no semantic change intended
In adafruit#2013, @danh says: My choice of where to put the semicolon is deliberate, so that we can say RUN_BACKGROUND_TASKS; not have a redundant semicolon, and not confuse C code formatting.
|
should this also be applied to HID as in #2050 ? Or is that outside the scope of your intent per your initial comment. |
|
@jerryneedell yes, #2050 would need further (trivial) modification if this goes in first. good catch. |
|
I’ll review this by Tuesday. Thanks! |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
OK, looks good - thank you! I'll push a change to fix the merge conflicts.
The indented XXX_MODULE entries in py/circuitpy_mpconfig.h were meant to show prerequisites, e.g. FONTIO_MODULE and TERMINAL_MODULE depend on DISPLAYIO_MODULE.
Restore dependencies indicated by indentation in circuitpy_mpconfig.h.
|
something weird about tinyusb update; investigating; don't merge yet |
|
Ouch, I obviously made a mistake in my git use. Do you want me to re-roll this whole PR to also get rid of the "reorder and reindent" part? @dhalbert |
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
OK, all set. The tinyusb commit was your change commit to tinyusb with the MIDI fix, but not the merge commit to the tinyusb repo that merged that in to the tip of master. That included a bunch of new changes to tinyusb: we'll have to update some code to handle those. I'll do another PR for that.
4 participants
I only touched the areas that I believe are specific to circuitpython, so as to reduce the chances of merge conflicts with upstream, so there are uses of the deprecated (to us) macro remaining.
Closes: #2013