WIP NotReady to merge - add shirtty board - hackaday supercon 2019 addon #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Nov 18, 2019
| @@ -0,0 +1,15 @@ | |||
| LD_FILE = boards/samd21x18-bootloader.ld | |||
| USB_VID = 0x239A | |||
| USB_PID = 0x801F | |||
Member
There was a problem hiding this comment.
USB VID and PID are something you cannot borrow from another board. So don't copy and paste these values! If you don't have a VID/PID pair, open up an issue in CircuitPython repository and request one, we will assist in the process of assigning a PID for use with CircuitPython.
Author
There was a problem hiding this comment.
Oops - Yes I am aware and fully understand. I wanted to get this PR opened ASAP after the conference. I will RTFM the guide on how to add a new board and update this. Changing the title to make it clear it's not ready to merge.
sarfata
changed the title
Author
|
Closing this. I will open a new PR against master once we have the VID/PID (#2322). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the circuitpython board for the trinket-m0 based shirtty board - as seen at Hackaday supercon 2019.
Repo for the hardware and software: https://github.com/sarfata/shirtty-addon.
@tannewt opening this as promised. Let me know if you have a doc/process on adding new boards.