Trinkey pixel fixes #4667
Merged
Trinkey pixel fixes #4667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
previously approved these changes
Apr 25, 2021
Author
|
Could someone give the CI approval again? I fixed the issue that caused it to fail last time. |
|
@ajs256 Thank you for this fix! I may not have time to test it today, but I will tomorrow for sure. I wanted to let you know that it is on my list. |
kattni
approved these changes
Apr 26, 2021
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Tested successfully on Neo Trinkey (neopixel_trinkey_m0)! Thank you for the fix!
|
As the others do not exist yet, I cannot test them. If there are issues, we'll catch them at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
board_reset_user_neopixelsto the Slidey Trinkey, NeoTrinkey, and Prox Trinkeyboard.cfiles to reset the NeoPixels when entering REPL.This is untested as I do not have hardware.
Closes #4601.