Skip to content

Conversation

@codetyphon
Copy link

No description provided.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks fine, so I enabled the CI to run and we'll see what the result is.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI found some problems. One problem:

Boards for job "build-xtensa" not sorted. Must be:
        - "adafruit_feather_esp32s2_nopsram"
        - "adafruit_feather_esp32s2_tftback_nopsram"
        - "adafruit_funhouse"
        - "adafruit_magtag_2.9_grayscale"
        - "adafruit_metro_esp32s2"
        - "artisense_rd00"
        - "atmegazero_esp32s2"
        - "electroniccats_bastwifi"
        - "espressif_kaluga_1"
        - "espressif_kaluga_1.3"
        - "espressif_saola_1_wroom"
        - "espressif_saola_1_wrover"
        - "franzininho_wifi_wroom"
        - "franzininho_wifi_wrover"
        - "gravitech_cucumber_m"
        - "gravitech_cucumber_ms"
        - "gravitech_cucumber_r"
        - "gravitech_cucumber_rs"
        - "hiibot_iots2"
        - "lilygo_ttgo_t8_s2_st7789"
        - "microdev_micro_s2"
        - "muselab_nanoesp32_s2_wroom"
        - "muselab_nanoesp32_s2_wrover"
        - "targett_module_clip_wroom"
        - "targett_module_clip_wrover"
        - "unexpectedmaker_feathers2"
        - "unexpectedmaker_feathers2_prerelease"
        - "unexpectedmaker_tinys2"

Other problem:

Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing ports/esp32s2/boards/hiibot_iots2/pins.c

Translations.............................................................Passed
Formatting...............................................................Passed
pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/ports/esp32s2/boards/hiibot_iots2/pins.c b/ports/esp32s2/boards/hiibot_iots2/pins.c
index 5e25c1490..a1f6bde4f 100755
--- a/ports/esp32s2/boards/hiibot_iots2/pins.c
+++ b/ports/esp32s2/boards/hiibot_iots2/pins.c
@@ -25,22 +25,22 @@ STATIC const mp_rom_map_elem_t board_global_dict_table[] = {
 
     { MP_ROM_QSTR(MP_QSTR_IO17), MP_ROM_PTR(&pin_GPIO17) },
     { MP_ROM_QSTR(MP_QSTR_DAC1), MP_ROM_PTR(&pin_GPIO17) },
-    
+
     { MP_ROM_QSTR(MP_QSTR_IO18), MP_ROM_PTR(&pin_GPIO18) },
     { MP_ROM_QSTR(MP_QSTR_DAC2), MP_ROM_PTR(&pin_GPIO18) },
-    
+
     { MP_ROM_QSTR(MP_QSTR_IO21), MP_ROM_PTR(&pin_GPIO21) },
     { MP_ROM_QSTR(MP_QSTR_BUTTON), MP_ROM_PTR(&pin_GPIO21) },
-    
+
     { MP_ROM_QSTR(MP_QSTR_IO33), MP_ROM_PTR(&pin_GPIO33) },
     { MP_ROM_QSTR(MP_QSTR_TFT_MOSI), MP_ROM_PTR(&pin_GPIO33) },
 
     { MP_ROM_QSTR(MP_QSTR_IO34), MP_ROM_PTR(&pin_GPIO34) },
     { MP_ROM_QSTR(MP_QSTR_TFT_SCK), MP_ROM_PTR(&pin_GPIO34) },
-    
+
     { MP_ROM_QSTR(MP_QSTR_IO35), MP_ROM_PTR(&pin_GPIO35) },
     { MP_ROM_QSTR(MP_QSTR_TFT_DC), MP_ROM_PTR(&pin_GPIO35) },
-    
+
     { MP_ROM_QSTR(MP_QSTR_IO36), MP_ROM_PTR(&pin_GPIO36) },
     { MP_ROM_QSTR(MP_QSTR_TFT_NSS), MP_ROM_PTR(&pin_GPIO36) },
 
@@ -49,7 +49,7 @@ STATIC const mp_rom_map_elem_t board_global_dict_table[] = {
 
     { MP_ROM_QSTR(MP_QSTR_IO38), MP_ROM_PTR(&pin_GPIO38) },
     { MP_ROM_QSTR(MP_QSTR_TFT_BL), MP_ROM_PTR(&pin_GPIO38) },
-    
+
     { MP_ROM_QSTR(MP_QSTR_IO40), MP_ROM_PTR(&pin_GPIO40) },
     { MP_ROM_QSTR(MP_QSTR_SCK), MP_ROM_PTR(&pin_GPIO40) },
 
Error: The process '/opt/hostedtoolcache/Python/3.9.6/x64/bin/pre-commit' failed with exit code 1

The pre-commit check is easy to perform locally, we describe how here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

I'm not sure of the simple way to check the other problem.

In any case, you can add new commits to this PR to resolve the problems and then we'll run the CI process again.

@tannewt
Copy link
Member

tannewt commented Aug 31, 2021

@codetyphon Care to finish this? Otherwise I'll close it. Thanks!

@tannewt tannewt closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants