Skip to content

Conversation

@ConradHughes
Copy link

Hi Adam,

Thanks for creating such a helpful script! Very useful for conforming old repos to GitHub's email security features.

I found the automatic lower-casing of the new email address conflicted with GitHub's default use of mixed case in email addresses (to match mixed case account names), so added this --preserve-new-email-case switch to disable the lower-casing (I know the addresses are case-insensitive, but the mismatch grated). Might be useful to others.

Best,
Conrad

@adamdehaven adamdehaven added the enhancement New feature or request label Feb 17, 2021
@adamdehaven adamdehaven self-assigned this Feb 17, 2021
@adamdehaven
Copy link
Owner

@ConradHughes I appreciate the feedback, and you caught something I hadn't really taken into account. I really appreciate the work you put into this pull request; however, I think the better solution is to not automatically transform the new email address to lowercase.

The script transforms the old email address to lowercase so that it will do a case-insensitive match when replacing in the commit history, but as you pointed out, for the new email address, it makes more sense to accept the email as the user provides it, as-is.

I have updated the script with this change in place, v2.3.1. You can download the update from the releases page and let me know if this works for you! 👍🏼

@adamdehaven adamdehaven added the good first issue Good for newcomers label Feb 17, 2021
@ConradHughes
Copy link
Author

All good — thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants