Skip to content

RFC: Pass the filename as the 2nd argument to the to function (shift remaining existing arguments by 1 to the right) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

RFC: Pass the filename as the 2nd argument to the to function (shift remaining existing arguments by 1 to the right) #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc9e4bc
Pass the filename as the 2nd argument to the to function (shift remai…
Sep 13, 2017
3472274
Fix for unit tests
Sep 13, 2017
5dc1d62
Remove second unnecessary check of typeof replacement
Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/replace-in-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function getReplacement(replace, isArray, i) {
/**
* Helper to make replacements
*/
function makeReplacements(contents, from, to) {
function makeReplacements(contents, from, to, file) {

//Turn into array
if (!Array.isArray(from)) {
Expand All @@ -95,10 +95,18 @@ function makeReplacements(contents, from, to) {
from.forEach((item, i) => {

//Get replacement value
const replacement = getReplacement(to, isArray, i);
let replacement = getReplacement(to, isArray, i);
if (replacement === null) {
return;
}
if (typeof replacement === 'function') {
const original = replacement;
replacement = function() {
const args = [].slice.call(arguments);
args.splice(1, 0, file);
return original.apply(null, args);
};
}

//Make replacement
contents = contents.replace(item, replacement);
Expand All @@ -117,7 +125,7 @@ function replaceSync(file, from, to, enc) {
const contents = fs.readFileSync(file, enc);

//Replace contents and check if anything changed
const newContents = makeReplacements(contents, from, to);
const newContents = makeReplacements(contents, from, to, file);
if (newContents === contents) {
return false;
}
Expand All @@ -139,7 +147,7 @@ function replaceAsync(file, from, to, enc) {
}

//Replace contents and check if anything changed
let newContents = makeReplacements(contents, from, to);
let newContents = makeReplacements(contents, from, to, file);
if (newContents === contents) {
return resolve({file, hasChanged: false});
}
Expand Down