Skip to content

test: refactored all tests#146

Merged
anuraghazra merged 16 commits intomasterfrom
test-refactor
Nov 10, 2020
Merged

test: refactored all tests#146
anuraghazra merged 16 commits intomasterfrom
test-refactor

Conversation

@anuraghazra
Copy link
Copy Markdown
Contributor

@anuraghazra anuraghazra commented Nov 10, 2020 •
edited
Loading

  • Made tests more resilient to changes in our code
  • Externalized snapshot tests
  • Simplified some tests
  • Used screen to do the assertion

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 10, 2020 •
edited
Loading

Deploy preview for renderless-components ready!

Built with commit 249e6c3

https://deploy-preview-146--renderless-components.netlify.app

@anuraghazra anuraghazra marked this pull request as ready for review November 10, 2020 14:18
@anuraghazra anuraghazra added the test 🧪 Pulls requests or issues related to testing label Nov 10, 2020
navin-moorthy
navin-moorthy approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@navin-moorthy navin-moorthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@anuraghazra anuraghazra merged commit e61a507 into master Nov 10, 2020
@anuraghazra anuraghazra deleted the test-refactor branch November 10, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@navin-moorthy navin-moorthy navin-moorthy approved these changes

Assignees

No one assigned

Labels

test 🧪 Pulls requests or issues related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anuraghazra @navin-moorthy