Timepicker v2#75
Merged
navin-moorthy merged 17 commits intotimepickerfrom Oct 9, 2020
Merged
Conversation
Closed
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 8, 2020
anuraghazra
reviewed
Oct 9, 2020
refactor(time-picker): ♻️ new timepicker state with much lesser code
refactor(types): 🏷️ update types for date,time & calendar
Also only accept string as value and return string in timepicker. Add storybook examples. Add autofocus support.
anuraghazra
reviewed
Oct 9, 2020
anuraghazra
approved these changes
Oct 9, 2020
Contributor
|
Noice! |
anuraghazra
added a commit
that referenced
this pull request
Oct 9, 2020
* chore: wip timepicker * feat: api v1 wip * feat: wip timepicker * feat: timepicker date meridies & added proper selection * chore: wip time picker disclosure * chore: onSelection handle * Timepicker v2 (#75) * feat(time-picker): ✨ improve timepicker with segment * fix(time-picker): 🐛 popover state usage & ts error with onchange * refactor(time-picker): ♻️ add combobox aria with keyboard navigation * refactor(time-picker): ♻️ move common types to utils * refactor(time-picker): ♻️ rename segment-spinner to segment * refactor(picker-base): ♻️ add picker base to date & time picker * refactor(time-picker): ♻️ new timepicker state with much lesser code * refactor(time-picker): ♻️ remove default value state & make utils * refactor(types): 🏷️ update types for date,time & calendar * refactor(types): 🏷️ arrange imports & update type comments * refactor(time-picker): ♻️ add pickerbase trigger to datepicker Also only accept string as value and return string in timepicker. Add storybook examples. Add autofocus support. * refactor(time-picker): ♻️ remove unused imports & useProps * fix: picker base role to button Co-authored-by: Anurag <hazru.anurag@gmail.com> Co-authored-by: Navin Moorthy <navin007.a@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.