Skip to content

test: added test for timepicker#86

Merged
anuraghazra merged 1 commit intomasterfrom
timepicker-tests
Oct 12, 2020
Merged

test: added test for timepicker#86
anuraghazra merged 1 commit intomasterfrom
timepicker-tests

Conversation

@anuraghazra
Copy link
Copy Markdown
Contributor

No description provided.

@anuraghazra anuraghazra added the test 🧪 Pulls requests or issues related to testing label Oct 12, 2020
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 12, 2020

Deploy preview for renderless-components ready!

Built with commit 8ec421f

https://deploy-preview-86--renderless-components.netlify.app

export interface TimePickerColumnInitialState extends ValueBase<Date> {
visible?: boolean;
type?: ColumnType;
columnType?: ColumnType;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the type to columnType because jestdom is throwing erros with because native elements also have type prop.

Copy link
Copy Markdown
Collaborator

@navin-moorthy navin-moorthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@anuraghazra anuraghazra merged commit 759e100 into master Oct 12, 2020
@anuraghazra anuraghazra deleted the timepicker-tests branch October 12, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test 🧪 Pulls requests or issues related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants