Skip to content

Let Canvas refresh when height is changed#694

Merged
malonecj merged 1 commit intoComcast:masterfrom
madprog:refresh-on-height-change
Mar 29, 2017
Merged

Let Canvas refresh when height is changed#694
malonecj merged 1 commit intoComcast:masterfrom
madprog:refresh-on-height-change

Conversation

@madprog
Copy link
Contributor

@madprog madprog commented Mar 13, 2017

Description

When the grid is resized with the window (e.g. it is in a flex box), its height is not updated all the time, because the shouldComponentUpdate method is not considering the height prop.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

When the grid is resized with the window (e.g. it is in a flex box), its height is not updated all the time.
image

What is the new behavior?

When the grid is resized with the window, its height is updated smoothly
image

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2a103c6 on madprog:refresh-on-height-change into ** on adazzle:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2a103c6 on madprog:refresh-on-height-change into ** on adazzle:master**.

@malonecj malonecj merged commit 0b91e3a into Comcast:master Mar 29, 2017
@madprog madprog deleted the refresh-on-height-change branch March 29, 2017 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants