[BUGFIX] minColumnWidth fix #753
Merged
bakesteve merged 3 commits intoComcast:masterfrom Jun 30, 2017
Merged
Conversation
|
Changes Unknown when pulling 8acbd45 on martinnov92:master into ** on adazzle:master**. |
Contributor
Author
Contributor
|
this looks good to me.. @malonecj please can you merge? |
Contributor
|
ps thank you so much for the videos @martinnov92 -- if only all PRs had them! 😛 |
Contributor
Author
|
@jpdriver Thank you too :) |
Contributor
Author
Contributor
|
would have already merged this if i could @martinnov92 ! unfortunately i can't help -- you'll just have to wait until Conor has time to look at it. |
Contributor
Author
|
@jpdriver Ok, thank you :) |
|
Bump. This is pretty crucial for a responsive table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello everyone,
in this pull request I tried to fix this weird behavior of not respecting minColumnWidth when resizing the window or grid.
Current situation is when you are resizing the window, all the columns are calculating its width and don't respect their set minColumnWidth which may cause that they become really small (here is the video), but after this fix, once their width become less then minColumnWidth, they keep the minColumnWidth - video
Hopefully I am not the only one who would appreciated this fix 😄 .
Thank you
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Current situation is when you are resizing the window, all the columns are calculating its width and don't respect their set minColumnWidth which may cause that they become really small (here is the video)
What is the new behavior?
After this fix, once their width become less then minColumnWidth, they keep the minColumnWidth - video
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: