Skip to content

Frozen column fixes for dyanically locking and unlocking columns#756

Merged
malonecj merged 4 commits intomasterfrom
sc-frozen-column-fixes
Apr 27, 2017
Merged

Frozen column fixes for dyanically locking and unlocking columns#756
malonecj merged 4 commits intomasterfrom
sc-frozen-column-fixes

Conversation

@sonny-chan
Copy link
Contributor

@sonny-chan sonny-chan commented Apr 20, 2017

Description

If a user is attempting to unlock columns dynamically while the grid is scrolled to the right - the original locked column header cells will not be visible due to the transform that was applied to it during the "locking".

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Attempting to unlock columns while scrolled causes the the original locked column header cells to not be visible.

What is the new behavior?
Unlocking columns will now show the original header cells so you can read the column name.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 86a6c8b on sc-frozen-column-fixes into ** on master**.

@malonecj malonecj merged commit 83d013b into master Apr 27, 2017
@malonecj malonecj deleted the sc-frozen-column-fixes branch February 8, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants