Skip to content

Issue 4779 - Application name wraps when displayed in app drawer #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Issue 4779 - Application name wraps when displayed in app drawer #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e51ad2b
Issue 4779 - Application name wraps when displayed in app drawer
fseto Jan 7, 2017
db54365
Issue 4779 - Launcher name wraps
fseto Jan 19, 2017
f654e13
Issue 4779 - Launcher name wraps
fseto Jan 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<application
android:allowBackup="true"
android:icon="@drawable/ic_launcher"
android:label="@string/app_name"
android:label="@string/launcher_name"
android:theme="@style/AppTheme" >
<activity
android:name="org.adblockplus.sbrowser.contentblocker.MainPreferences"
Expand Down
1 change: 1 addition & 0 deletions res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<resources>

<string name="app_name">Adblock Plus for Samsung Internet</string>
<string name="launcher_name">Adblock Plus</string>
Copy link
Contributor

@diegocarloslima diegocarloslima Jan 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing, you need to use this launcher_name string in AndroidManifest. Under the <application> tag, change the label to android:label="@string/launcher_name"

Copy link
Author

@fseto fseto Jan 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your continued guidance Diego! I have updated AndroidManifest.

<string name="automatic_updates">Configure automatic updates</string>
<string name="manage_subscriptions">Configure your filter lists</string>
<string name="manage_subscriptions_summary">Change ad blocking languages</string>
Expand Down