feat: extend type ergonomics to response types #106
Merged
+511
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the same BeforeValidator coercion pattern from PR #103 to response types. This eliminates the need for cast() calls when constructing response objects with subclass instances or dict coercion. Response types now support: - Dict coercion for context/ext fields - Subclass list acceptance for products, creatives, formats, packages, errors, and media_buy_deliveries Closes #105 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update response type tests to import from public API (adcp.types) instead of internal generated_poc modules - Use semantic alias CreateMediaBuySuccessResponse instead of CreateMediaBuyResponse1 for clearer intent - Add clarifying comments for # type: ignore annotations explaining Python list covariance limitation - Add tests for GetProductsResponse.products subclass acceptance - Add tests for errors field coercion - Document _ergonomic.py in CLAUDE.md import architecture section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
contextandextfieldsproducts,creatives,formats,packages,errors,creative_agents, andmedia_buy_deliveriesThis eliminates the need for
cast()calls when constructing response objects with subclass instances.Response types with coercion:
GetProductsResponseListCreativesResponseListCreativeFormatsResponseCreateMediaBuyResponse1GetMediaBuyDeliveryResponseTest plan
Closes #105
🤖 Generated with Claude Code