feat: export missing types from stable API #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iceGuidance from stable API Add missing types to stable.py public API: - FormatId: Format identifier type (agent_url + id) - PackageRequest: Request structure for creating packages - PushNotificationConfig: Webhook push notification configuration - PriceGuidance: Pricing guidance for auction-based options (floor, percentiles) These types are commonly used in AdCP workflows and should be part of the stable public API to avoid users importing from internal generated modules. Changes: - Add types to adcp.types.stable imports and __all__ - Add types to adcp.__init__.py imports and __all__ - Group PriceGuidance with other pricing types - Add new "Configuration types" section for PushNotificationConfig All types are properly exported from both stable.py and main package. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add four commonly-used types to the stable public API that were previously only accessible from internal modules:
These types are referenced in workflows and should be available from the stable API to prevent users from importing internal generated types.
Test plan
adcppackageadcp.types.stable__all__exports