Skip to content

feat: export missing types from stable API #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+20 −2
Merged

feat: export missing types from stable API #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/adcp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
Error,
FlatRatePricingOption,
Format,
FormatId,
GetMediaBuyDeliveryRequest,
GetMediaBuyDeliveryResponse,
GetProductsRequest,
Expand All @@ -147,14 +148,17 @@
MediaBuy,
MediaBuyStatus,
Package,
PackageRequest,
PackageStatus,
PreviewCreativeRequest,
PreviewCreativeResponse,
PriceGuidance,
PricingModel,
Product,
Property,
ProvidePerformanceFeedbackRequest,
ProvidePerformanceFeedbackResponse,
PushNotificationConfig,
SyncCreativesRequest,
SyncCreativesResponse,
UpdateMediaBuyRequest,
Expand Down Expand Up @@ -214,6 +218,7 @@
"ProvidePerformanceFeedbackResponse",
"Error",
"Format",
"FormatId",
"Product",
"Property",
# Core domain types (from stable API)
Expand All @@ -222,23 +227,27 @@
"CreativeManifest",
"MediaBuy",
"Package",
"PackageRequest",
# Package type aliases
"CreatedPackageReference",
# Status enums (for control flow)
"CreativeStatus",
"MediaBuyStatus",
"PackageStatus",
"PricingModel",
# Pricing options (all 9 types)
# Pricing-related types
"CpcPricingOption",
"CpcvPricingOption",
"CpmAuctionPricingOption",
"CpmFixedRatePricingOption",
"CppPricingOption",
"CpvPricingOption",
"FlatRatePricingOption",
"PriceGuidance",
"VcpmAuctionPricingOption",
"VcpmFixedRatePricingOption",
# Configuration types
"PushNotificationConfig",
# Adagents validation
"AuthorizationContext",
"fetch_adagents",
Expand Down
11 changes: 10 additions & 1 deletion src/adcp/types/stable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
Error,
FlatRatePricingOption,
Format,
FormatId,
GetMediaBuyDeliveryRequest,
GetMediaBuyDeliveryResponse,
GetProductsRequest,
Expand All @@ -66,14 +67,17 @@
MarkdownAsset,
MediaBuy,
MediaBuyStatus,
PackageRequest,
PackageStatus,
PreviewCreativeRequest,
PreviewCreativeResponse,
PriceGuidance,
PricingModel,
Product,
Property,
ProvidePerformanceFeedbackRequest,
ProvidePerformanceFeedbackResponse,
PushNotificationConfig,
SyncCreativesRequest,
SyncCreativesResponse,
TasksGetRequest,
Expand Down Expand Up @@ -143,18 +147,21 @@
"CreativeManifest",
"Error",
"Format",
"FormatId",
"MediaBuy",
"Package",
"PackageRequest",
"Product",
"Property",
# Pricing options
# Pricing-related types
"CpcPricingOption",
"CpcvPricingOption",
"CpmAuctionPricingOption",
"CpmFixedRatePricingOption",
"CppPricingOption",
"CpvPricingOption",
"FlatRatePricingOption",
"PriceGuidance",
"VcpmAuctionPricingOption",
"VcpmFixedRatePricingOption",
# Status enums
Expand All @@ -164,6 +171,8 @@
"PricingModel",
"TaskStatus",
"TaskType",
# Configuration types
"PushNotificationConfig",
# Assets
"AudioAsset",
"CssAsset",
Expand Down