feat: discriminated union support in type generation #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull latest AdCP schemas (v1.0.0) with new destination and deployment types - Add discriminated union generation for oneOf schemas with type discriminators - Handle const fields for proper Literal types in discriminators - Add missing ActivationKey type alias for deployment schema Changes to type generation: - New `generate_discriminated_union()` function handles oneOf schemas - Automatically detects discriminator field (type) and generates typed variants - Example: Destination = PlatformDestination | AgentDestination - Each variant gets proper Literal["platform"] | Literal["agent"] type New types added: - PlatformDestination / AgentDestination (discriminated union) - PlatformDeployment / AgentDeployment (discriminated union) - ActivationKey type alias Improved existing types: - BrandManifestRef now discriminated union (was Any) - StartTiming now discriminated union (was Any) - PricingOption now discriminated union (was Any) All tests pass with Python 3.11+. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pull latest AdCP schemas (v1.0.0) and improve type generation to handle discriminated unions with proper type discrimination. Destination and Deployment types now use
oneOfwith discriminators, resulting in much better type safety and IDE support.Changes
generate_discriminated_union()function handlesoneOfschemas, automatically detecting discriminators and generating typed variantsconstfields to generateLiteraltypes (e.g.,Literal["platform"])AnyAll 114 tests pass. ✅