feat: Add ergonomic type aliases and public API exports #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve developer experience by providing semantic type names that match the AdCP spec: - CreateMediaBuySuccessResponse / CreateMediaBuyErrorResponse instead of Response1/2 - Re-export all commonly-used request/response types from main package - Add PEP 561 py.typed marker for full type checker support - Update documentation with import guidelines and examples Users can now import cleanly from adcp without relying on internal modules. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Nov 18, 2025
Improve developer experience by providing semantic type names that match the AdCP spec: - CreateMediaBuySuccessResponse / CreateMediaBuyErrorResponse instead of Response1/2 - Re-export all commonly-used request/response types from main package - Add PEP 561 py.typed marker for full type checker support - Update documentation with import guidelines and examples Users can now import cleanly from adcp without relying on internal modules. 🤖 Generated with Claude Code Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves developer experience by providing semantic type names that match the AdCP specification. Users can now import cleanly from the main
adcppackage without relying on internal modules.CreateMediaBuySuccessResponseinstead ofCreateMediaBuyResponse1py.typedmarker for full type checker supportTest plan
🤖 Generated with Claude Code