Feature/code improvements

SampleAppSwiftUI/Configs/AppStore.xcconfig

@@ -11,6 +11,6 @@
 
 base_url = https:/$()/min-api.cryptocompare.com/data/
 
-webSocket_base_url = wss:/$()/streamer.cryptocompare.com/v2?api_key=%@
+webSocket_base_url = wss:/$()/streamer.cryptocompare.com/v2
 
 personal_api =

SampleAppSwiftUI/Configs/Development.xcconfig

@@ -13,6 +13,6 @@ PRODUCT_BUNDLE_IDENTIFIER = com.adesso.SampleAppSwiftUI.development
 
 base_url = https:/$()/min-api.cryptocompare.com/data/
 
-webSocket_base_url = wss:/$()/streamer.cryptocompare.com/v2?api_key=%@
+webSocket_base_url = wss:/$()/streamer.cryptocompare.com/v2
 
 personal_api =

SampleAppSwiftUI/Configs/Production.xcconfig

@@ -13,6 +13,6 @@ PRODUCT_BUNDLE_IDENTIFIER = com.adesso.SampleAppSwiftUI.prod
 
 base_url = https:/$()/min-api.cryptocompare.com/data/
 
-webSocket_base_url = wss:/$()/streamer.cryptocompare.com/v2?api_key=%@
+webSocket_base_url = wss:/$()/streamer.cryptocompare.com/v2
 
 personal_api = 

SampleAppSwiftUI/Network/WebSocket/WebSocketEndpoint.swift

@@ -18,7 +18,7 @@ enum WebSocketEndpoint: TargetEndpointProtocol {
     var path: String {
         switch self {
             case .baseCoinApi:
-            return String(format: Constants.webSocketEndpoint, Constants.apiKey)
+            return Constants.webSocketEndpoint
         }
     }
 }

SampleAppSwiftUI/Network/WebSocket/WebSocketProvider.swift

@@ -15,7 +15,9 @@ class WebSocketProvider: NSObject {
     init? (endPoint: TargetEndpointProtocol = WebSocketEndpoint.baseCoinApi,
            session: URLSession = URLSession.shared ) {
         guard let url = URL(string: WebSocketEndpoint.baseCoinApi.path) else { return nil }
-        self.socket = WebSocketStream(url: url,
+        let query = URLQueryItem(name: "api_key", value: Configuration.coinApiKey)
+        let finalURL = url.appending(queryItems: [query])
+        self.socket = WebSocketStream(url: finalURL,
                                       session: session)
     }
 }

SampleAppSwiftUI/Network/WebSocket/WebSocketSubscription.swift

@@ -42,7 +42,7 @@ class WebSocketSubscription<S: Subscriber>: Subscription where S.Input == URLSes
                 _ = subscriber.receive(message)
             }
         } catch {
-            debugPrint("Someting went wrong")
+            debugPrint("Something went wrong")
         }
     }
 }

SampleAppSwiftUI/Resources/Constants/URLs.swift

@@ -9,11 +9,12 @@ import Foundation
 
 enum URLs {
     enum Icons {
-        static let baseURL = "https://assets.coincap.io/assets/icons/"
+        static let baseURL = "https://assets.coincap.io"
+        static let iconPath = "/assets/icons/"
         static let scaleURL = "@2x.png"
 
         static func getURL(from coinCode: CoinCode) -> URL? {
-            URL(string: "\(baseURL)\(coinCode.lowercased())\(scaleURL)")
+            URL(string: "\(baseURL)\(iconPath)\(coinCode.lowercased())\(scaleURL)")
         }
     }
 }

SampleAppSwiftUI/Scenes/Favorites/FavoritesViewModel.swift

@@ -41,10 +41,12 @@ class FavoritesViewModel: ObservableObject {
     }
 
     func fetchFavorites() {
-        DispatchQueue.main.async {
-            self.isLoading = false
-            self.getFavoriteCoinList()
-            self.startSocketConnection()
+        if Configuration.coinApiKey.isNotEmpty {
+            DispatchQueue.main.async {
+                self.isLoading = false
+                self.getFavoriteCoinList()
+                self.startSocketConnection()
+            }
         }
     }
 

SampleAppSwiftUI/Utility/Extensions/ArrayExtensions.swift

@@ -25,4 +25,8 @@ extension Array: RawRepresentable where Element: Codable {
         }
         return result
     }
+
+    public var isNotEmpty: Bool {
+        !self.isEmpty
+    }
 }

SampleAppSwiftUI/Utility/Extensions/StringExtensions.swift

@@ -24,4 +24,8 @@ extension String {
     static var empty: Self {
         ""
     }
+
+    public var isNotEmpty: Bool {
+        !self.isEmpty
+    }
 }