Skip to content

Conversation

@guanguans
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #11 (7ea318a) into main (9728489) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main       #11   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        70        70           
===========================================
  Files              2         2           
  Lines            143       143           
===========================================
  Hits             143       143           
Impacted Files Coverage Δ
src/Fixer.php 100.00% <ø> (ø)
src/PadsJson.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adhocore
Copy link
Owner

thank you, Travis seems failing. if you could paste in screenshot of tests passing then we are good to go.
(later we can move to GitHub actions for tests)

@guanguans
Copy link
Contributor Author

I'm sorry.

@guanguans guanguans closed this Nov 30, 2022
@adhocore adhocore reopened this Nov 30, 2022
@adhocore
Copy link
Owner

no need to sorry. the PR is good :)
pls make build pass so we can merge it. thank you 💯

@guanguans
Copy link
Contributor Author

For compatibility with differences between php and phpunit versions, I remove the method of setUp.
The build of action has passed.

--protected function setUp()
++protected function setUp(): void
{
}

@adhocore
Copy link
Owner

adhocore commented Dec 1, 2022

thanks 👍

@adhocore adhocore merged commit 3849208 into adhocore:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants