Skip to content
This repository was archived by the owner on Apr 3, 2025. It is now read-only.

Fix and improve /etc/exports updates #60

Merged
merged 3 commits into from
Jun 6, 2016
Merged

Fix and improve /etc/exports updates #60

merged 3 commits into from
Jun 6, 2016

Conversation

@achekulaev
Copy link
Contributor

Fixes:

  • Propery remove old bindings from /etc/exports (not just check for duplicates)
  • Fix bug that boot2docker configuration was not updated properly in some cases

Improvements:

  • Make exports bindings machine dependent (so that removing bindings for one machine would not affect other)

Alexei Chekulaev added 3 commits June 3, 2016 14:28
Fix and improve /etc/exports changes. Properly remove old bindings. M…
c0514f6 
…ake them machine-name dependent
Fix the bug that changing shared dir to parent one would not update b…
995452f 
…oot2docker configuration.

i.e. if old share was "/Users/macuser" and new one is "/Users" then isNFSMounted would wrongfully report that NFS already mounted
Convert tabs to spaces for code style to be inline with the rest of t…
34cf0d5 
…he file
@tonivdv
Copy link
Member

tonivdv commented Jun 4, 2016

Hey @achekulaev ,

Thanks for this PR. I will check this asap.

@tonivdv tonivdv merged commit 7d080eb into adlogix:master Jun 6, 2016
@tonivdv
Copy link
Member

tonivdv commented Jun 6, 2016

It works fine. Thanks for the contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achekulaev @tonivdv