Vesion for review phase - do not do any changes

README.md

@@ -1,19 +1,62 @@
+# Legal Note
+
+Despite great efforts to ensure the accuracy, reliability and precision of technical and non-technical information, the IDTA cannot give any explicit or implicit assurance or warranty in respect of the accuracy of the provided aspect models for BatteryPass. 
+Users of this document are hereby made aware that the IDTA cannot be held liable for any damage or loss. 
+The application of these aspect models does not release users from the bility for their own actions and is applied at their own risk.
+
 # Semantic Models
 
-This repository is for aspect models that are used as semantic definition in Submodel Templates.
+This repository is for aspect models that are used as semantic definition in [Submodel Templates](https://github.com/admin-shell-io/submodel-templates).
 
-They are used in the so-called "Semantic Drived workflow" as desribed in [HOW TO CREATE A SUBMODEL TEMPLATE
-SPECIFICATION](https://industrialdigitaltwin.org/en/wp-content/uploads/sites/2/2022/12/I40-IDTA-WS-Process-How-to-write-a-SMT-FINAL-.pdf)
+They are used in the so-called "Semantic driven workflow" as desribed in [HOW TO CREATE A SUBMODEL TEMPLATE
+SPECIFICATION](https://industrialdigitaltwin.org/wp-content/uploads/2025/06/IDTA_How-to-write-a-SMT-v1.1.pdf).
 
-Here semantic models based on the [Semantic Aspect Meta Model (SAMM)](https://eclipse-esmf.github.io/samm-specification) are stored. Additionally [best practices](https://eclipse-esmf.github.io/samm-specification/snapshot/appendix/best-practices.html) as defined in the SAMM specification should be followed.
+Here semantic models based on the [Semantic Aspect Meta Model (SAMM)](https://eclipse-esmf.github.io/samm-specification) are stored. 
+[Best practices](https://eclipse-esmf.github.io/samm-specification/snapshot/appendix/best-practices.html) as defined in the SAMM specification should be followed.
 
-They belong to the namespaces starting with *io.admin-shell.idta*.
+They belong to the namespaces starting with **io.admin-shell.idta**.
 
-Models can reuse elements from different namespaces.
+Models can reuse elements from different namespaces within the repository.
 
 When defining and reusing elements from other aspect models, the following repositories with aspect models are allowed to be used besides the ones in this repository:
 
 * [Catena-X aspect models](https://github.com/eclipse-tractusx/sldt-semantic-models), their namespaces start with *io.catenax*
+* [BatteryPass aspect models](https://github.com/batterypass/BatteryPassDataModel), their namespaces start with *io.BatteryPass* - however, please note that these aspect models have licence **CC BY-NC 4.0**.
+
+
+# Generator used
+
+The following [CLI - Semantic Aspect Meta Model Command Line Tool](https://eclipse-esmf.github.io/esmf-developer-guide/tooling-guide/samm-cli.html) was used for
+
+* validating the aspect models
+* for generating the different files in folder "gen"
+
+  * *.aas.json JSON format for AAS
+  * *.aas.xml  XML format for AAS
+  * *.aasx  [aasx format](https://industrialdigitaltwin.io/aas-specifications/IDTA-01005/v3.1/index.html) for AAS
+  * *.html  hmtl documentation of the Aspect Model
+  * *.json  example payload in [Value-Only format](https://industrialdigitaltwin.io/aas-specifications/IDTA-01001/v3.1/mappings/mappings.html#value-only-serialization-in-json)
+
+
+Version: 2.10.3
+
+Build date: 2025-05-08T14:47:57Z
+
+Git commit: 192116d12a1a4c9df4e03758a6b56dfa80132cf3
+
+
+# Known issues for generation of aasx from aspect model
+
+Known Issues wheen generating an aasx file from a .ttl aspect model file:
 
+- payload names are not considered when generating idShort
+- no template qualifiers with type "Cardinality" or any other qualifiers are generated
+- the idShort of the Element within a SML has the idShort of the list, not of the element
+- no mapping to SubmodelElement "File", instead mapping to SMC with two properties "resourceValue" and "contentType"
+- no example values generated, neither as "value" nor as qualifier using the template qualifier "SMT/ExampleValue"
+- semanticId only added for Properties but not for SMC or SML (but ConceptDescriptions are derived)
+- Concept Descriptions: For enumerations no valueList is created for its values (example :HazardousSubstanceClassChrateristicEnum in MaterialComposition)
+- Concept Descriptions: The preferred name is identical to the element name and not the samm:preferred name of the samm:property
+- for some models the generated Submodel/id and Submodel/semanticId are not correct and need to be updated manually
 
 

README_OpenQuestions.md

@@ -0,0 +1,75 @@
+
+# Open Questions
+
+
+
+
+## Deviations from manually edited aasx of WG
+
+* Open Questions:
+
+  * How to deal with different requirements for different battery categories: mandatory, recommended and optional?
+
+
+
+	* Nameplate: it is AddressInformation and not ContactInformation
+	* Nameplate: logoCompany is missing
+	* Nameplate/Markings: explosionSafeties not  contained in V3.0 any longer
+	* Nameplate/ContactInformation: is a dropin and contains much more properties
+
+* ProductCondition
+## TODOs for BatteryPass reused
+https://github.com/batterypass/BatteryPassDataModel/issues/17
+
+    * remainingEnergy: property name should be remainingEnergyValue and not remainingEnergyvalue
+	* why is evolutionOfSelfDischarge a SMC with just one Property evolutionOfSelfDischargeEntityValue? "lastValue" missing?
+	* names of lists like "internalResistanceIncrease" or remainingPowerCapability
+    * no "lastUpdate" for energyThroughput
+	* no "lastUpdate" for roundTripEfficencyFade
+	* no "lastUpdate" for roundTripEfficiencyat50PerCentCycleLife 
+	* naming roundTripEfficiencyat50PerCentCycleLife should be roundTripEfficiencyAt50PercentCycleLife
+	* Circularity/safetyMeasures is a Link to a pdf, here it is a SMC with a SML of extinguishingAgents... Extinguishing agent are mentioned in DIN SPEC 99100 but as Symbols/Labels and documentation for conformity
+	* Circularity/endOfLifeInformation not part of DIN SPEC 991100 ?
+	* Circularity/renewable Content not part of DIN SPEC 991100 ?
+	* Two Alternatives to model NegativeEvents, see ProductCondition_shared.ttl or solution of BatteryPass?
+
+
+
+## Circularity
+https://github.com/batterypass/BatteryPassDataModel/issues/17
+
+	* dismantlinAndRemovalInformation mdoelled as a DocumentSet from Handover Documentation? (it is a SML with SMC with properties documentType, mimeType and documentURL" - we probably need to extend the numbers (or map it to existing ones) of supported document types in Handover Documentation:
+	     ** dismantling information(DIN SPEC 99100 speaks of two documents for dismantling and removal)
+		 ** removal information (DIN SPEC 99100 speaks of two documents for dismantling and removal)
+		 ** safety measures
+		 EU declaration of conformity
+		 Results of test reports proving compliance
+		 Web link to public carbon footprint study
+		 Information of due diligence report in the Battery Passport
+		 Information on the role of end-users in contributing to waste prevention
+		 Information on the role of end-users in contributing to the separate collection of waste batteries
+		 Information on battery collection, preparation for second life and on treatment at end of life
+
+## MaterialComposition
+
+https://github.com/batterypass/BatteryPassDataModel/issues/18
+* > bp:CASNumberConstraint :
+  The the exampleValue '7439-93-2 ' of the Property 'bp:batteryMaterialIdentifier' does not match the pattern '^\d{2,7}-\d{2}-\d{1}$' given in 'bp:CASNumberConstraint'.
+
+## Other	
+
+* license information not put to description but to README
+
+* formatting in case of lists in descriptions etc.: rework needed
+
+* DIN SPEC 99100: why is Part Numbers for components an URL?
+* Circularity/sparePartSources might be using contactInformation for Postal Addresses
+* do we have a SMT for spare parts?
+
+* TO BE DECIDED:
+  DocumentSet per aspect, for Circularity etc. - or really in ONE aspect Handover Documentation?
+
+* unit in SAMM - define a "real" unit?
+		:kilogramperkilowatthour a samm:Unit ;
+		   samm:commonCode "kg CO2e/kWh" ;
+		   samm:symbol "CO2e/kWh" .

io.admin-shell.idta.batterypass.carbon_footprint/1.0.0/CarbonFootprint.ttl

@@ -0,0 +1,55 @@
+######################################################################
+# for namespace: urn:samm:io.admin-shell.idta.
+# Copyright (c) 2025 Bosch Connected Industry
+# Copyright (c) 2025 Industrial Digital Twin Association
+#
+# This work  is made available under the terms of the
+# Creative Commons Attribution 4.0 International (CC BY 4.0) license,
+# which is available at
+# https://creativecommons.org/licenses/by/4.0/.
+# SPDX-License-Identifier: CC-BY-4.0
+#
+# for namespace: urn:samm:io.catenax.pcf:7.0.0
+# Copyright (c) 2022, 2023, 2024 ZF Friedrichshafen AG
+# Copyright (c) 2022, 2023, 2024 T-Systems International GmbH
+# Copyright (c) 2022, 2023, 2024 Robert Bosch Manufacturing Solutions GmbH
+# Copyright (c) 2022, 2023, 2024 Siemens AG
+# Copyright (c) 2022, 2023, 2024 SAP AG
+# Copyright (c) 2022, 2023, 2024 BASF SE
+# Copyright (c) 2022, 2023, 2024 Contributors to the Eclipse Foundation
+#
+# This work is made available under the terms of the
+# Creative Commons Attribution 4.0 International (CC-BY-4.0) license,
+# which is available at
+# https://creativecommons.org/licenses/by/4.0/legalcode.
+#
+# SPDX-License-Identifier: CC-BY-4.0
+#######################################################################
+
+#######################################################################
+
+@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.1.0#> .
+@prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.1.0#> .
+@prefix samm-e: <urn:samm:org.eclipse.esmf.samm:entity:2.1.0#> .
+@prefix unit: <urn:samm:org.eclipse.esmf.samm:unit:2.1.0#> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix : <urn:samm:io.admin-shell.idta.batterypass.carbon_footprint:1.0.0#> .
+@prefix pcf: <urn:samm:io.admin-shell.idta.carbon_footprint:1.0.0#> .
+@prefix cx: <urn:samm:io.catenax.pcf:7.0.0#> .
+@prefix ext-shared: <urn:samm:io.admin-shell.idta.shared:3.1.0#> .
+@prefix contact: <urn:samm:io.admin-shell.idta.contact_information:1.0.0#> .
+
+:CarbonFootprint a samm:Aspect ;
+   samm:preferredName "Carbon Footprint for Battery Passport"@en ;
+   samm:preferredName "C02 Footprint für den Batteriepass"@de ;
+   samm:description "Provides the means to access the Carbon Footprint of the asset in the context of a Battery Passport."@en ;
+   samm:see <https://admin-shell.io/idta/SubmodelTemplate/CarbonFootprint/1/0> ;
+   samm:see <https://admin-shell.io/IDTA-02035-3/1/0> ;
+   samm:see <https://admin-shell.io/IDTA-02023/1/0> ;
+   samm:properties ( 
+   [ samm:property pcf:productCarbonFootprints; samm:payloadName "ProductCarbonFootprints" ] 
+   ) ;
+   samm:operations ( ) ;
+   samm:events ( ) .