incorporate findings #4

io.admin-shell.idta.batterypass.circularity/1.0.0/gen/CircularityBattery.json

@@ -1,14 +1,14 @@
 {
-  "renewableContent" : -5.8001647E37,
+  "renewableContent" : -2.1837363E37,
   "dismantlingAndRemovalInformation" : [ {
     "documentType" : "BillOfMaterial",
     "mimeType" : "eOMtThyhVNLWUZNRcBaQKxI",
     "documentURL" : "telnet://192.0.2.16:80/"
   } ],
   "recycledContent" : [ {
-    "preConsumerShare" : 13.106601,
+    "preConsumerShare" : 10.607893,
     "recycledMaterial" : "Cobalt",
-    "postConsumerShare" : 72.10663
+    "postConsumerShare" : 33.179176
   } ],
   "endOfLifeInformation" : {
     "separateCollection" : "ftp://ftp.is.co.za/rfc/rfc1808.txt",
@@ -26,7 +26,7 @@
       "partNumber" : "JxkyvRnL"
     } ],
     "supplierWebAddress" : "ftp://ftp.is.co.za/rfc/rfc1808.txt",
-    "emailAddressOfSupplier" : "w.--w-ww..-.-..w--..w--w--.-.w.ww..@.ww...-.--www-.www-w.w-www-w-ww.ww.w---w..w...-ww..w...-.w.....-.-.w.w-ww.w.w.-..-w.ww.-.%ueZnybuEIBnpaLxlbLGAdRIBZSNJCsjgxSYGpJScqjkEBfFnquPzOhReBlqWvAIGPloBUYpmAwRJIVxmPOcANEfrmhALedcKMTj",
+    "emailAddressOfSupplier" : "_OvVbXekX5HQwY@_rbhBQ2xnofB-GgoI-A6ipWuuoA2jXKT4.F0kGWa0-IMEV5kUt4_1o2v5JglgM4p9lw.UVxfMeuzYDwdYqoIMVTBNDJSDzuZhmktphCDnlCIdIJnetVzbkiArrqDrRCfmilG",
     "addressOfSupplier" : {
       "addressCountry" : "Germany",
       "streetAddress" : "Street 1",

io.admin-shell.idta.batterypass.circularity/README.md

@@ -23,7 +23,7 @@ Source Content Hub of the IDTA: [IDTA-02035-7 V1.2]()
 # Dependencies
 
 This model is using the models of the BatteryPass Consortium: https://github.com/batterypass/BatteryPassDataModel
-with license CC BY-NC 4.0.
+with license CC BY 4.0.
 
 
 # Changelog

io.admin-shell.idta.batterypass.handover_documentation/1.0.0/gen/HandoverDocumentationBattery.json

@@ -5,6 +5,13 @@
       "DocumentIsPrimary" : true,
       "DocumentDomainId" : "1213455566"
     } ],
+    "DocumentedEntities" : [ {
+      "type" : "ModelReference",
+      "keys" : [ {
+        "value" : "id1234",
+        "key" : "Submodel"
+      } ]
+    } ],
     "DocumentVersions" : [ {
       "Description" : [ {
         "en" : "Example multi language string"
@@ -28,7 +35,6 @@
       "Title" : [ {
         "en" : "Example multi language string"
       } ],
-      "Languages" : [ "en" ],
       "RefersToEntities" : [ {
         "type" : "ModelReference",
         "keys" : [ {
@@ -43,6 +49,7 @@
         "en" : "Example multi language string"
       } ],
       "OrganizationShortName" : "Example company",
+      "Language" : [ "en" ],
       "Version" : "V1.2",
       "StatusValue" : "Released",
       "OrganizationOfficialName" : "Example company Ltd.",

io.admin-shell.idta.batterypass.handover_documentation/README.md

@@ -18,8 +18,7 @@ The battery passport consists of the following 7 parts:
 
 # General
 
-The folder "gen" for each version contains sammple JSON files generated for the aspect model(s)
-The folder "input" contains source files like .aasx or the submodel template specification itself
+The folder "gen" for each version contains sammple JSON files and html generated for the aspect model(s)
 
 # Changelog
 All notable changes to this model will be documented in this section.

io.admin-shell.idta.batterypass.material_composition/1.0.0/gen/MaterialCompositionBattery.json

@@ -7,7 +7,7 @@
     "hazardousSubstanceClass" : "AcuteToxicity",
     "hazardousSubstanceConcentration" : -1.7976931348623157E308,
     "hazardousSubstanceImpact" : [ "JxkyvRnL" ],
-    "hazardousSubstanceIdentifier" : "434-02-3",
+    "hazardousSubstanceIdentifier" : "251-00-5",
     "hazardousSubstanceLocation" : {
       "componentName" : "Anode",
       "componentId" : "RYtGKbgicZaHCBRQDSx"
@@ -16,7 +16,7 @@
   } ],
   "batteryMaterials" : [ {
     "batteryMaterialIdentifier" : "7439-93-2",
-    "batteryMaterialMass" : -2.7345223E38,
+    "batteryMaterialMass" : -2.9150972E38,
     "batteryMaterialName" : "Lithium",
     "batteryMaterialLocation" : {
       "componentName" : "Anode",

io.admin-shell.idta.batterypass.material_composition/README.md

@@ -20,6 +20,9 @@ with license CC BY-NC 4.0.
 Source GitHub IDTA: https://github.com/admin-shell-io/submodel-templates 
 Source Content Hub of the IDTA: [IDTA-02035-6 V1.2]()
 
+# General
+
+The folder "gen" for each version contains sammple JSON files and html generated for the aspect model(s)
 
 # Changelog
 All notable changes to this model will be documented in this section.
@@ -33,14 +36,11 @@ Contained Files:
 * MaterialComposition.ttl
 
 
-
 Dependencies:
 
 * urn:samm:io.BatteryPass.MaterialComposition:1.2.0
 
-Known Issues:
 
-* semanticId of Submodel is not correctly generated by the ESMF CLI
 
 
 

io.admin-shell.idta.batterypass.product_condition/1.0.0/gen/ProductConditionBattery.json

@@ -1,61 +1,61 @@
 {
   "StateOfCharge" : {
-    "stateOfChargeValue" : -4.5244504E37,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "stateOfChargeValue" : -2.4808245E38,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "RemainingCapacity" : {
-    "remainingCapacityValue" : -2.6293122E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "remainingCapacityValue" : -1.6792607E38,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "NegativeEvents" : [ {
     "negativeEvent" : "eOMtThyhVNLWUZNRcBaQKxI",
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   } ],
   "TemperatureInformation" : {
     "timeExtremeHighTemp" : -1.7976931348623157E308,
     "timeExtremeLowTempCharging" : -1.7976931348623157E308,
     "timeExtremeHighTempCharging" : -1.7976931348623157E308,
     "timeExtremeLowTemp" : -1.7976931348623157E308,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "CurrentSelfDischargingRate" : {
-    "currentSelfDischargingRateValue" : 1.6927761E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "currentSelfDischargingRateValue" : 2.0836378E37,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "RemainingEnergy" : {
-    "remainingEnergyValue" : 1.4426504E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "remainingEnergyValue" : -2.4276854E38,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "EnergyThroughput" : {
-    "energyThroughputValue" : -2.3654153E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "energyThroughputValue" : -2.0987542E38,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "StateOfCertifiedEnergy" : {
-    "stateOfCertifiedEnergyValue" : -2.0236418E37,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "stateOfCertifiedEnergyValue" : -1.1928056E37,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "EvolutionOfSelfDischarge" : {
-    "evolutionOfSelfDischargeValue" : 1.0642763E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "evolutionOfSelfDischargeValue" : 3.3607428E37,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "RemainingRoundTripEnergyEfficiency" : {
-    "remainingRoundTripEnergyEfficiencyValue" : 3.278879E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "remainingRoundTripEnergyEfficiencyValue" : 8.3691297E37,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "CapacityThroughput" : {
-    "capacityThroughputValue" : 3.2927993E38,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "capacityThroughputValue" : 2.5012476E38,
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "RemainingPowerCapability" : {
     "remainingPowerCapabilityValue" : {
-      "atSoC" : 3.9312857E37,
-      "powerCapabilityAt" : -2.7240384E38,
-      "rPCLastUpdated" : "2025-10-24T12:53:55.823+02:00"
+      "atSoC" : -6.2131663E37,
+      "powerCapabilityAt" : 2.2036495E38,
+      "rPCLastUpdated" : "2025-11-17T12:48:41.984+01:00"
     },
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   },
   "NumberOfFullCycles" : {
     "numberOfFullCyclesValue" : -179769313486231570000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000,
-    "lastUpdate" : "2025-10-24T12:53:55.823+02:00"
+    "lastUpdate" : "2025-11-17T12:48:41.984+01:00"
   }
 }

io.admin-shell.idta.batterypass.product_condition/1.0.0/gen/ProductConditionBatteryStationaryLMT.json

@@ -1,62 +1,62 @@
 {
   "StateOfCharge" : {
-    "stateOfChargeValue" : -1.3776493E38,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "stateOfChargeValue" : 2.7062998E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "RemainingCapacity" : {
-    "remainingCapacityValue" : 1.6583406E38,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "remainingCapacityValue" : -3.2608352E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
-  "RoundTripEfficiencyFade" : -1.8475411E38,
+  "RoundTripEfficiencyFade" : -1.1845248E37,
   "NegativeEvents" : [ {
     "negativeEvent" : "eOMtThyhVNLWUZNRcBaQKxI",
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   } ],
   "TemperatureInformation" : {
     "timeExtremeHighTemp" : -1.7976931348623157E308,
     "timeExtremeLowTempCharging" : -1.7976931348623157E308,
     "timeExtremeHighTempCharging" : -1.7976931348623157E308,
     "timeExtremeLowTemp" : -1.7976931348623157E308,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "CurrentSelfDischargingRate" : {
-    "currentSelfDischargingRateValue" : -1.8860528E37,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "currentSelfDischargingRateValue" : -2.457422E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "RemainingEnergy" : {
-    "remainingEnergyValue" : 2.0704639E38,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "remainingEnergyValue" : 2.7428854E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "EnergyThroughput" : {
-    "energyThroughputValue" : 2.0514739E38,
-    "lastUpdate" : "2025-10-24T12:54:26.170+02:00"
+    "energyThroughputValue" : 2.4958773E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "StateOfCertifiedEnergy" : {
-    "stateOfCertifiedEnergyValue" : -2.2149416E38,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "stateOfCertifiedEnergyValue" : -5.651014E37,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "EvolutionOfSelfDischarge" : {
-    "evolutionOfSelfDischargeValue" : -5.842055E37,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "evolutionOfSelfDischargeValue" : -1.8180649E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "RemainingRoundTripEnergyEfficiency" : {
-    "remainingRoundTripEnergyEfficiencyValue" : 1.1550909E38,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "remainingRoundTripEnergyEfficiencyValue" : -1.0687386E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "CapacityThroughput" : {
-    "capacityThroughputValue" : 6.0614387E37,
-    "lastUpdate" : "2025-10-24T12:54:26.170+02:00"
+    "capacityThroughputValue" : 2.9160381E38,
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "RemainingPowerCapability" : {
     "remainingPowerCapabilityValue" : {
-      "atSoC" : 2.385188E38,
-      "powerCapabilityAt" : 2.2399396E38,
-      "rPCLastUpdated" : "2025-10-24T12:54:26.171+02:00"
+      "atSoC" : -2.0115788E38,
+      "powerCapabilityAt" : -3.1549398E38,
+      "rPCLastUpdated" : "2025-11-17T12:49:10.372+01:00"
     },
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   },
   "NumberOfFullCycles" : {
     "numberOfFullCyclesValue" : -179769313486231570000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000,
-    "lastUpdate" : "2025-10-24T12:54:26.171+02:00"
+    "lastUpdate" : "2025-11-17T12:49:10.372+01:00"
   }
 }

io.admin-shell.idta.batterypass.product_condition/README.md

@@ -23,7 +23,7 @@ Source Content Hub of the IDTA: [IDTA-02035-5 V1.2]()
 # Dependencies
 
 This model is using  models or model elements of the BatteryPass Consortium: https://github.com/batterypass/BatteryPassDataModel
-with license CC BY-NC 4.0.
+with license CC BY 4.0.
 
 
 
@@ -45,4 +45,4 @@ Dependencies:
 * urn:samm:io.BatteryPass.Performance:1.2.0
 
 Deviations:
-* informationOnAccidents is modelled as a DocumentSet (reuse from SMT HandoverDocumentation), in DIN SPEC 99100 it is described as a Reference to a pdf File.  
+* informationOnAccidents is modelled as a DocumentSet (reuse from SMT HandoverDocumentation), in DIN DKE SPEC 99100 it is described as a Reference to a pdf File.  

io.admin-shell.idta.batterypass.technical_data/1.0.0/TechnicalData.ttl

@@ -18,7 +18,7 @@
 # SPDX-License-Identifier: CC-BY-4.0
 #######################################################################
 
-#@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.1.0#> .
+@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.1.0#> .
 @prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.1.0#> .
 @prefix samm-e: <urn:samm:org.eclipse.esmf.samm:entity:2.1.0#> .
 @prefix unit: <urn:samm:org.eclipse.esmf.samm:unit:2.1.0#> .

io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.json

@@ -9,22 +9,22 @@
       "InitialInternalResistanceOnBatteryModule" : 10.0
     },
     "PowerCapability" : {
-      "RatioNominalBatteryPowerAndBatteryEnergy" : 1.5213282E38,
-      "PowerFade" : -7.015649E37,
+      "RatioNominalBatteryPowerAndBatteryEnergy" : -1.3459633E38,
+      "PowerFade" : 1.8062715E38,
       "MaximumPermittedBatteryPower" : "Infinity",
       "OriginalPowerCapability" : [ {
-        "atSoC" : 1.7341337E37,
-        "powerCapabilityAt" : -2.2925729E38
+        "atSoC" : -1.95873E38,
+        "powerCapabilityAt" : -1.4488341E38
       } ]
     },
     "CapacityEnergyVoltage" : {
-      "CertifiedUsableBatteryEnergy" : 3.1516585E37,
+      "CertifiedUsableBatteryEnergy" : 1.4277476E38,
       "CapacityFade" : {
-        "capacityFadeValue" : -8.3394616E37,
-        "lastUpdate" : "2025-10-24T12:55:06.211+02:00"
+        "capacityFadeValue" : 2.8539727E38,
+        "lastUpdate" : "2025-11-17T12:49:36.148+01:00"
       },
       "NominalVoltage" : 4.3,
-      "RatedCapacity" : 2.2624908E38,
+      "RatedCapacity" : -2.1056177E38,
       "MaxVoltage" : 6.0,
       "MinVoltage" : 2.04
     },
@@ -34,16 +34,16 @@
     },
     "Lifetime" : {
       "CapacityThresholdExhaustion" : -1.7976931348623157E308,
-      "CrateOfRelevantCycleLifeTest" : -8.651704E37,
-      "NumberOfChargeDischargeCycles" : -8614686800807876267,
-      "ExpectedLifetimeInCalendarYears " : -3481
+      "CrateOfRelevantCycleLifeTest" : 6.9033114E35,
+      "NumberOfChargeDischargeCycles" : -906119171975329752,
+      "ExpectedLifetimeInCalendarYears " : 2854
     },
     "RoundTripEnergyEfficiency" : {
       "InitialRoundTripEnergyEfficiency" : 100,
-      "RoundTripEnergyEfficiencyAtFiftyofCycleLife" : 2.0009588E37,
+      "RoundTripEnergyEfficiencyAtFiftyofCycleLife" : -2.6983016E38,
       "EnergyRoundTripEfficiencyFade" : {
-        "capacityFadeValue" : -2.3760305E38,
-        "lastUpdate" : "2025-10-24T12:55:06.211+02:00"
+        "capacityFadeValue" : 9.551916E37,
+        "lastUpdate" : "2025-11-17T12:49:36.148+01:00"
       },
       "InitialSelfDischargingRate" : 2
     }
@@ -62,7 +62,7 @@
     } ],
     "ManufacturerOrderCode" : "JxkyvRnL",
     "ManufacturerArticleNumber" : "yedUsFwdkelQbxeTeQOvaScfqIOOmaa",
-    "WarrantyPeriod" : "--10",
+    "WarrantyPeriod" : "--11",
     "ManufacturerIdentifier" : "RYtGKbgicZaHCBRQDSx"
   }
 }

io.admin-shell.idta.batterypass.technical_data/README.md

@@ -107,10 +107,7 @@ to GenerationInformation:
 * in BatteryPass CurrentSelfDischargingRateValue is float, here InitialSelfDischargingRate is integer. Same for InitialRoundTripEnergyEfficiency, here integer, in BatteryPass for example RemainingRoundTripEnergyEfficiencyValue is float
 
 
-## Open Questions
+### Open issues
 
-### still open properties of Efficiency
-### still open properties of Resistance
-### for consistency SMC for TemperatureRangeIdleStateBoundaries should be introduced ?
-### should be remove optional [ samm:property tech:productClassifications; samm:optional true ] from generic Technical Data? We should if we do not have a recommendation what to add there
+* https://github.com/batterypass/BatteryPassDataModel/issues/33 Warrenty VS Warranty (Payload name already Warranty)