fix #258: Private key decryption fails in py3 #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base problem was that cryptodome's RSA.key.exportKey produces bytes, which in py3 have to be decoded to produce a string. So first we decode them (using the 'ascii' decoder, because it's PEM data), and then (for py2 compatibility) we coerce the decode result to a string. * Also fixed the example umapi config file to have the correct name for secure private keys (`secure_priv_key_data_key`), which was reported in the same bug. * Also fixed the doc sources (in English only, because the translations hadn't yet picked up this section) not to include the same buggy example as the config file. * Also fixed the handling of AssertionError not to expect the exception to have a `message` field. * Also updated the version number and release notes in case we want to produce a release with only this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base problem was that cryptodome's RSA.key.exportKey produces bytes, which in py3 have to be decoded to produce a string. So first we decode them (using the 'ascii' decoder, because it's PEM data), and then (for py2 compatibility) we coerce the decode result to a string.
secure_priv_key_data_key), which was reported in the same bug.messagefield.