Skip to content

Pull typecast Messaging Proposition for getPropositionsForSurface API #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 29, 2025
Merged

Pull typecast Messaging Proposition for getPropositionsForSurface API #536

merged 16 commits into from
Sep 29, 2025

Conversation

cacheung
Copy link
Contributor

@cacheung cacheung commented Sep 29, 2025 •
edited
Loading

  • Pull typecast Messaging Proposition for getPropositionsForSurface API from staging update the messaging.ts
  • fix the Sample app only show Remote View issue.
  • fix ci
    • enable corepack
    • Add memory for yarn install (NODE_OPTIONS: "--max-old-space-size=4096") and network timeout
    • Jest Test (moduleNameMapper + transformIgnorePatterns in jest.config.js)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

cacheung and others added 15 commits September 25, 2025 15:17
@cacheung
Fix the Rendered fewer hooks than expected error when clicking dismiss
53b7332 
Fix the issue, when users clicked the dismiss button on ContentCardView.tsx, the app crashed with React's hooks consistency error.
"Rendered fewer hooks than expected. This may be caused by an accidental early return statement"
@ishita-gambhir-adobe @cacheung
[Messaging] typecast Messaging Proposition for getPropositionsForSurf…
1d0e5c5 
…ace API (adobe#534)

* typecast Messaging Proposition

* update README

* update README
@cacheung
remove conversion
1db16a1 
remove conversion
@cacheung
remove old mapping for tracking
f4c83f4 
remove old mapping for tracking
@cacheung
Fix the different views from content card.
be76b66 
It was showing only Remote view in the sample app event choose other selectedViews.
@cacheung
Enable Corepack for ci to fix the test and indention issue
6f27668 
Enable Corepack for ci to fix the test and indention issue
@cacheung
fix react-native import error for "test"
2d0fd9a 
fix react-native import error for "test"
@cacheung
update sample package dependency
9848a41 
update sample package dependency
@cacheung
update yarn.lock file
895b911 
update yarn.lock file
@cacheung
fix CI test
f97033b 
fix CI test
@cacheung
add timeout for ci steps
06bd3b4 
add timeout for ci steps
@cacheung
fix ci tests
a89c153 
fix ci tests
@cacheung
remove -network-concurrency
5146482 
remove -network-concurrency
@cacheung
fix config indentation
723718c 
fix config indentation
@cacheung
Increasing the memory limit from 4GB,
1ec3f07 
Increasing the memory limit from 4GB,
@cacheung
update for Rendered fewer hooks than expected error" when clicking di…
d5bf3f5 
…smiss

update for Rendered fewer hooks than expected error" when clicking dismiss
@cacheung cacheung merged commit 189fe94 into adobe:content-card-ui Sep 29, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsoffiantini dsoffiantini dsoffiantini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cacheung @dsoffiantini @ishita-gambhir-adobe