Skip to content

Fix cyclic definitions for props table #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 14, 2020
Merged

Fix cyclic definitions for props table #407

merged 7 commits into from
Apr 14, 2020

Conversation

snowystinger
Copy link
Member

Debugging docs build for cyclic types
Closes

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger changed the title WIP Listbox docs Fix cyclic definitions for props tabble Apr 13, 2020
@snowystinger snowystinger changed the title Fix cyclic definitions for props tabble Fix cyclic definitions for props table Apr 13, 2020
devongovett
devongovett reviewed Apr 14, 2020
View reviewed changes
packages/@react-spectrum/listbox/src/ListBox.tsx


/**
* Listbox shows lists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@devongovett devongovett merged commit a1c8ba6 into master Apr 14, 2020
@devongovett devongovett deleted the listbox-documentation branch April 14, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@dannify dannify Awaiting requested review from dannify

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snowystinger @adobe-bot @devongovett