-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix cyclic definitions for props table #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8e106ba
Debugging docs build for cyclic types
snowystinger 65d7a88
I think I've resolved all the bugs I was dealing with to render the p…
snowystinger 7ad88ba
Correct component name for title
snowystinger 8c0ae52
Rename variable
snowystinger 71cad8a
Merge branch 'master' into listbox-documentation
snowystinger fe0c5b4
remove early return
snowystinger 2fc7ad2
remove extra console log
snowystinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<!-- Copyright 2020 Adobe. All rights reserved. | ||
This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. You may obtain a copy | ||
of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software distributed under | ||
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
OF ANY KIND, either express or implied. See the License for the specific language | ||
governing permissions and limitations under the License. --> | ||
|
||
import {Layout} from '@react-spectrum/docs'; | ||
export default Layout; | ||
|
||
import docs from 'docs:@react-spectrum/listbox'; | ||
import {HeaderInfo, PropTable} from '@react-spectrum/docs'; | ||
import packageData from '../package.json'; | ||
|
||
```jsx import | ||
import {ListBox, Section, Item} from '@react-spectrum/listbox'; | ||
``` | ||
|
||
# ListBox | ||
|
||
<p>{docs.exports.ListBox.description}</p> | ||
|
||
<HeaderInfo | ||
packageData={packageData} | ||
componentNames={['ListBox']} /> | ||
|
||
## Example | ||
|
||
```tsx example | ||
<ListBox width={200} aria-label="label"> | ||
<Section title="Justify"> | ||
<Item>Left</Item> | ||
<Item>Middle</Item> | ||
<Item>Right</Item> | ||
</Section> | ||
<Section title="Align"> | ||
<Item>Top</Item> | ||
<Item>Center</Item> | ||
<Item>Bottom</Item> | ||
</Section> | ||
</ListBox> | ||
``` | ||
|
||
## Content | ||
|
||
### Accessibility | ||
|
||
### Internationalization | ||
|
||
## Events | ||
|
||
## Props | ||
|
||
<PropTable component={docs.exports.ListBox} links={docs.links} /> | ||
|
||
## Visual Options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆