docs: s2 docs quick fixes #8967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
reidbarber
approved these changes
Oct 3, 2025
yihuiliao
commented
Oct 4, 2025
|
|
||
| function Example() { | ||
| let [expandedKeys, setExpandedKeys] = useState(new Set<Key>(['system'])); | ||
| let [expandedKeys, setExpandedKeys] = useState(new Set<Key>(['settings'])); |
There was a problem hiding this comment.
maybe leftover from a copy paste but noticed that our example didn't have key with "system" so updated it
LFDanLu
approved these changes
Oct 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
not sure why it keeps failing on the react 17 tests, will have to look into that test separately |
LFDanLu
pushed a commit
that referenced
this pull request
Oct 9, 2025
* docs: update the expanded key in s2 accordion docs * increase gap between icons in available icons * fix focus ring on search menu tabs
devongovett
pushed a commit
that referenced
this pull request
Oct 9, 2025
* docs: update the expanded key in s2 accordion docs * increase gap between icons in available icons * fix focus ring on search menu tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: