Skip to content

docs: s2 docs quick fixes #8967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2025
Merged

docs: s2 docs quick fixes #8967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b854d05
docs: update the expanded key in s2 accordion docs
yihuiliao Oct 1, 2025
045b13c
Merge branch 'main' into s2-doc-quick-fix
yihuiliao Oct 2, 2025
2ffa41c
increase gap between icons in available icons
yihuiliao Oct 2, 2025
bca549e
fix focus ring on search menu tabs
yihuiliao Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dev/s2-docs/pages/s2/Accordion.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {Accordion, Disclosure, DisclosureTitle, DisclosurePanel, type Key} from
import {useState} from 'react';

function Example() {
let [expandedKeys, setExpandedKeys] = useState(new Set<Key>(['system']));
let [expandedKeys, setExpandedKeys] = useState(new Set<Key>(['settings']));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe leftover from a copy paste but noticed that our example didn't have key with "system" so updated it


return (
<Accordion
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/s2-docs/src/IconCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function IconCards() {
<Autocomplete filter={filter}>
<div className={style({display: 'flex', flexDirection: 'column', gap: 8})}>
<SearchField size="L" aria-label="Search icons" placeholder="Search icons" />
<Virtualizer layout={GridLayout} layoutOptions={{minItemSize: new Size(64, 64), maxItemSize: new Size(64, 64), minSpace: new Size(8, 8), preserveAspectRatio: true}}>
<Virtualizer layout={GridLayout} layoutOptions={{minItemSize: new Size(64, 64), maxItemSize: new Size(64, 64), minSpace: new Size(12, 12), preserveAspectRatio: true}}>
<ListBox
onAction={(item) => handleCopyImport(item.toString())}
items={iconList}
Expand Down
25 changes: 22 additions & 3 deletions packages/dev/s2-docs/src/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const tablist = style({
paddingStart: 12,
flexShrink: 0,
flexBasis: '[0%]',
gap: 32,
gap: 24,
maxWidth: 240,
height: 'full',
paddingY: 4
Expand Down Expand Up @@ -161,7 +161,7 @@ function TabLine(props: TabLineProps) {
);
}

const tab = style<TabRenderProps & {density?: 'compact' | 'regular', labelBehavior?: 'show' | 'hide'}>({
const tab = style<TabRenderProps & {density?: 'compact' | 'regular', orientation?: 'vertical' | 'horizontal', labelBehavior?: 'show' | 'hide'}>({
...focusRing(),
display: 'flex',
color: {
Expand All @@ -173,7 +173,26 @@ const tab = style<TabRenderProps & {density?: 'compact' | 'regular', labelBehavi
},
borderRadius: 'sm',
gap: 'text-to-visual',
height: 48,
height: {
orientation: {
horizontal: {
density: {
compact: 32,
regular: 48
}
}
}
},
minHeight: {
orientation: {
vertical: {
density: {
compact: 32,
regular: 48
}
}
}
},
alignItems: 'center',
position: 'relative',
cursor: 'default',
Expand Down