-
Notifications
You must be signed in to change notification settings - Fork 0
fix: agent executor slack notification #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR will trigger a patch release when merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the agent executor's Slack notification system by introducing structured notification payloads that support rich formatting with blocks and attachments. The changes enable agents (specifically brand-profile) to return detailed notification content that flows through the agent-executor to the slack-notify handler.
Key Changes
- Extended slack-notify handler to support nested message payloads with blocks and attachments
- Added notification normalization in agent-executor to extract and validate notification payloads from persist metadata
- Enhanced brand-profile agent to return rich Slack blocks with profile highlights and contextual information
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tasks/slack-notify/handler.js | Added support for nested message payloads with blocks/attachments, and validation for structured content |
| src/tasks/agent-executor/handler.js | Added normalizeNotifications function to extract and validate notification payloads from persist results |
| src/agents/brand-profile/index.js | Enhanced persist function to generate rich Slack notification blocks with brand profile highlights |
| test/tasks/slack-notify/slack-notify.test.js | Added comprehensive tests for message payload handling, blocks, attachments, and validation |
| test/tasks/agent-executor/agent-executor.test.js | Added tests for notification normalization and filtering of invalid payloads |
| test/agents/brand-profile/index.test.js | Updated tests to verify notification block generation with profile data |
| .github/copilot-instructions.md | New file containing PR review guidelines and instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
## [1.6.3](v1.6.2...v1.6.3) (2025-11-19) ### Bug Fixes * agent executor slack notification ([#137](#137)) ([382ef79](382ef79))
|
🎉 This PR is included in version 1.6.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Overview
brand-profileagent with Azure OpenAI prompts, persistence, and notification metadata.slack-notifyhandler capable of consuming structured payloads (text/blocks/attachments) and reuses shared Slack utilities.README.md; includes PR-ready changelog.Motivation
Testing
npm test(full suite) – all unit tests plus optional IT test guard.