chore(combobox): s2 fast follows fix #5202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 275275e The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 14125197918Details
💛 - Coveralls |
Rajdeepc
added
Component: Combobox
Spectrum CSS
ready-for-review
fast-follow
marissahuysentruyt
force-pushed
the
rajdeep/combobox-fastfollows
branch
2 times, most recently
from
c18b13f to
3998d91
Compare
- corrects the s2 foundations disabled border color - corrects the s2 foundations focus+hover border color
marissahuysentruyt
force-pushed
the
rajdeep/combobox-fastfollows
branch
from
3998d91 to
a0bcc97
Compare
* fix(pickerbutton): s2 foundations fast follows * chore(pickerbutton): create changeset --------- Co-authored-by: Rajdeep Chandra <rajrock38@gmail.com>
…be/spectrum-web-components into rajdeep/combobox-fastfollows
Rajdeepc
force-pushed
the
rajdeep/combobox-fastfollows
branch
from
de82d8f to
60ab985
Compare
castastrophe
pushed a commit
that referenced
this pull request
Apr 1, 2025
* chore(combobox): s2 fast follows fix * ci: updated golden image cache * chore: updated textfield and pickerbutton to latest to support s2 combobox css updates * chore: updated tokens * chore: upgraded picker button to its latest * chore(combobox): s2 fast follows fix * ci: updated golden image cache * fix(combobox): design feedback updates - corrects the s2 foundations disabled border color - corrects the s2 foundations focus+hover border color * chore(combobox): create changeset * fix(pickerbutton): picker button version update (#5252) * fix(pickerbutton): s2 foundations fast follows * chore(pickerbutton): create changeset --------- Co-authored-by: Rajdeep Chandra <rajrock38@gmail.com> * ci: updated golden image cache * chore: updated yarn lock * chore: css changes * ci: updated golden image cache --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@rajdeeps-mbp-2.macromedia.com> Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Marissa Huysentruyt <marissa.huysentruyt@heysparkbox.com> Co-authored-by: Marissa Huysentruyt <69602589+marissahuysentruyt@users.noreply.github.com> Co-authored-by: Casey Eickhoff <48574582+caseyisonit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combobox fast follows fixes.
Motivation and context
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.