refactor: simplify generate:manifest error handling #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Ace correctly exits with code 1 on error, there is no need to check stderr. This also prevents us from interpreting output from deprecation warnings as manifest generation errors.
|
How about the check that looks for malformed ace-manifest file and then re-attempts to generate the file? |
|
Shouldn't that case also end up in the |
|
Ohhh wait. I thought both checks (one inside the catch block) has been removed. But that's not the case. So we are all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Ace correctly exits with code 1 on error, there is no need to
check stderr. This also prevents us from interpreting output from
deprecation warnings as manifest generation errors.