Skip to content

refactor: simplify generate:manifest error handling #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2021
Merged

refactor: simplify generate:manifest error handling #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/Manifest/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,6 @@ export class Manifest {
},
})

/**
* Print warning when `stderr` exists
*/
if (response.stderr) {
if (this.isMalformedJSONError(response.stderr) && this.attempts < this.maxAttempts) {
this.attempts++
return this.generate()
}

this.logger.warning(WARN_MESSAGE)
this.logger.logError(response.stderr)
return false
}

/**
* Log success
*/
Expand Down
4 changes: 2 additions & 2 deletions test/compiler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ test.group('Compiler', (group) => {
assert.isTrue(hasPackageLock)
}).timeout(0)

test('gracefully log error when ace file writes to stderr', async (assert) => {
test('gracefully log error when ace file finishes with non-zero exit code', async (assert) => {
await fs.add(
'.adonisrc.json',
JSON.stringify({
Expand All @@ -624,7 +624,7 @@ test.group('Compiler', (group) => {
})
)

await fs.add('ace', "console.error('foo')")
await fs.add('ace', "console.error('foo');process.exit(1)")
await fs.add('src/foo.ts', '')
await fs.add('public/styles/main.css', '')
await fs.add('public/scripts/main.js', '')
Expand Down