Fix store.cleanSnapshots for redis implementation#127
Merged
adrai merged 2 commits intothenativeweb:masterfrom Apr 30, 2018
Merged
Fix store.cleanSnapshots for redis implementation#127adrai merged 2 commits intothenativeweb:masterfrom
adrai merged 2 commits intothenativeweb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
If you have an
EventStoreinstance of typeredisincluding a non-zeromaxSnapshotsCount(for example,maxSnapshotsCount: 5),When you have fewer than 5 snapshots (i.e. 0), and you call something like:
Then you will see this error:
(NOTE: the snapshot does get created correctly, but then the return value errors because
cleanSnapshotsfails).Now
You can call
es.createSnapshot(snap, cb)without the error fromcleanSnapshots.@adrai hope this is helpful, and let me know if you see any changes you'd like made. Thanks.
(Fixes #126)