Skip to content

Fix eventmappings when value is empty or 0#61

Merged
adrai merged 2 commits intothenativeweb:masterfrom
rehia:empty-eventmappings
Feb 29, 2016
Merged

Fix eventmappings when value is empty or 0#61
adrai merged 2 commits intothenativeweb:masterfrom
rehia:empty-eventmappings

Conversation

@rehia
Copy link
Copy Markdown
Contributor

@rehia rehia commented Feb 29, 2016

For streamRevision, for example, because 1st revision value is 0, streamRevision is not copied in the payload : the value is bypassed because of the test in the if statement

For streamRevision, for example, because 1st revision value is 0, streamRevision is not copied in the payload
@adrai
Copy link
Copy Markdown
Contributor

adrai commented Feb 29, 2016

can you refactor the isNullOrUndefined function to work with node 0.10 too?

@rehia
Copy link
Copy Markdown
Contributor Author

rehia commented Feb 29, 2016

Is that a "no-luck" CI failure ?

adrai added a commit that referenced this pull request Feb 29, 2016
Fix eventmappings when value is empty or 0
@adrai adrai merged commit 5de6210 into thenativeweb:master Feb 29, 2016
@adrai
Copy link
Copy Markdown
Contributor

adrai commented Feb 29, 2016

v1.7.1

@rehia
Copy link
Copy Markdown
Contributor Author

rehia commented Mar 2, 2016

Thanks for the merge and the publishing!

@rehia rehia deleted the empty-eventmappings branch March 2, 2016 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants