Skip to content

fix Atlas product -> images relations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix Atlas product -> images relations #4

merged 1 commit into from
Jun 18, 2020

Conversation

@yoh
Copy link

@yoh yoh commented May 5, 2020

I think the image relation must target images.imageable_id instead of images.id ?!

@yoh
fix Atlas product -> images relations
62107f8 
I think the `image` relation must target `images.imageable_id` instead of `images.id` ?!
@yoh
Copy link
Author

yoh commented May 5, 2020

For information, the results on my VM (debian / php 7.2 / 2gb ram) with NB_TEST = 1000 :
Thx for your work !

⇒  php TestRunner.php
|-------------------------------------------------------------------------------------------------------|
| Library                          | Insert | Update | Find   | Complex| EagerL. | memory usage|  time  |
| --------------------------------:| ------:| ------:| ------:| ------:| -------:| -----------:| ------:|
|                         AtlasOrm |    341 |    199 |     53 |    183 |    1064 |   7,948,192 |   1.93 |
|-------------------------------------------------------------------------------------------------------|
|                         CycleOrm |    374 |    242 |     44 |    211 |    1179 |  10,022,224 |   2.17 |
|      CycleOrmWithGeneratedMapper |    338 |    220 |     34 |    214 |    1107 |  12,116,112 |   2.10 |
|            CycleOrmDynamicSchema |    323 |    217 |     40 |    211 |    1202 |   9,989,696 |   2.09 |
|-------------------------------------------------------------------------------------------------------|
|                        DoctrineM |    238 |    115 |    184 |    114 |    2077 |  12,582,912 |   2.90 |
|               DoctrineMWithCache |    227 |    120 |    182 |    111 |    2094 |  12,582,912 |   2.94 |
|-------------------------------------------------------------------------------------------------------|
|                         Eloquent |    608 |    309 |     84 |    253 |    1353 |   2,097,152 |   2.68 |
|             EloquentWithoutEvent |    557 |    276 |     78 |    251 |    1289 |   2,097,152 |   2.53 |
|-------------------------------------------------------------------------------------------------------|
|                        SiriusOrm |    506 |    370 |     61 |    188 |    1026 |   5,847,952 |   2.21 |
|-------------------------------------------------------------------------------------------------------|
|                         MedooOrm |    147 |     69 |     24 |     71 |     634 |   1,641,888 |   0.96 |
|-------------------------------------------------------------------------------------------------------|

@adrianmiu adrianmiu merged commit f0c1066 into adrianmiu:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoh @adrianmiu