Skip to content

Export component #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 11, 2020
Merged

Export component #22

merged 8 commits into from
Sep 11, 2020

Conversation

@twoplustwoone
Copy link
Contributor

@twoplustwoone twoplustwoone commented Sep 9, 2020 •
edited
Loading

Resolves #21

@twoplustwoone twoplustwoone changed the title Export component fixes #21 Export component Sep 9, 2020
jarrodek
jarrodek requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@jarrodek jarrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great job. Few things though:

  • change the main and module in the package.json to index.js.
  • create index.js with just the export statement with the main class.
  • if possible upgrade dev dependencies. There are multiple audit errors.

@twoplustwoone
Copy link
Contributor Author

twoplustwoone commented Sep 10, 2020

Updated dev dependencies and ran npm audit fix

jarrodek
jarrodek approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@jarrodek jarrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twoplustwoone twoplustwoone merged commit 9822f8e into stage Sep 11, 2020
@twoplustwoone twoplustwoone deleted the chore/export-component branch September 11, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarrodek jarrodek jarrodek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestion: export ApiDocumentation

3 participants

@twoplustwoone @jarrodek