Skip to content

W-10704893 Add dynamic property maxHeight #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 3, 2022
Merged

W-10704893 Add dynamic property maxHeight #28

merged 16 commits into from
Mar 3, 2022

Conversation

@alexpmule
Copy link
Contributor

@alexpmule alexpmule commented Feb 25, 2022 •
edited
Loading

Description

Make maxHeight dynamic
Ticket in GUS

Technical changes

  • Added var --api-resource-example-document-max-height to class .renderer
  • Added unit test for css variable
  • Added table of definition of properties in README.md

Results

With --api-resource-example-document-max-height set in 100px

155819854-8d6b9cc3-7164-4677-9b08-69db76743448.mov

Without --api-resource-example-document-max-height set

Screen.Recording.2022-02-25.at.16.48.18.mov

Issue type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The created branch follows branching convention: fix/W-x/, feat/W-x/, test/W-x/* or chore/W-x/*
  • The commit messages have the GUS ticket.
  • The PR is rebased with base branch.
  • I added tests.
  • I validated the fix manually.
  • I have performed a self-review of my own code
  • This change requires documentation update
  • This change includes library / dependency update.
  • My changes generate no new warnings

@alexpmule alexpmule requested a review from jarrodek February 25, 2022 13:46
@alexpmule alexpmule self-assigned this Feb 25, 2022
@alexpmule alexpmule removed the request for review from jarrodek February 25, 2022 13:46
@alexpmule alexpmule changed the title Add dynamic property minHeight + test Add dynamic property maxHeight + test Feb 26, 2022
@alexpmule alexpmule changed the title Add dynamic property maxHeight + test W-10704893 Add dynamic property maxHeight + test Feb 26, 2022
@alexpmule alexpmule changed the title W-10704893 Add dynamic property maxHeight + test W-10704893 Add dynamic property maxHeight Feb 26, 2022
@alexpmule alexpmule marked this pull request as ready for review February 26, 2022 00:20
jarrodek
jarrodek previously requested changes Feb 26, 2022
View reviewed changes
@alexpmule alexpmule requested a review from jarrodek March 1, 2022 22:57
twoplustwoone
twoplustwoone suggested changes Mar 2, 2022
View reviewed changes
twoplustwoone
twoplustwoone reviewed Mar 2, 2022
View reviewed changes
@jarrodek
Copy link
Member

jarrodek commented Mar 2, 2022

This LGTM now but what with the tests? They still have maxHeight property and it looks like they are passing. Is there something wrong with the tests?

@alexpmule alexpmule marked this pull request as draft March 3, 2022 12:30
@alexpmule alexpmule removed the request for review from carowright March 3, 2022 12:31
@alexpmule alexpmule removed the request for review from jarrodek March 3, 2022 12:31
@alexpmule alexpmule marked this pull request as ready for review March 3, 2022 13:28
twoplustwoone
twoplustwoone previously approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@twoplustwoone twoplustwoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexpmule alexpmule requested a review from twoplustwoone March 3, 2022 13:36
jarrodek
jarrodek approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@jarrodek jarrodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexpmule alexpmule dismissed jarrodek’s stale review March 3, 2022 17:13

I fixed all your comments and hints

@alexpmule alexpmule merged commit 2cd48b5 into master Mar 3, 2022
@alexpmule alexpmule deleted the feat/W-10704893-make-dinamyc-minheight-in-example-panel branch March 3, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarrodek jarrodek jarrodek approved these changes

+1 more reviewer

@twoplustwoone twoplustwoone twoplustwoone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexpmule alexpmule

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexpmule @jarrodek @twoplustwoone