This repository was archived by the owner on Apr 4, 2025. It is now read-only.
CVE-2021-44228 #12
Merged
CVE-2021-44228 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
securingdev
reviewed
Dec 10, 2021
Contributor
securingdev
left a comment
securingdev
left a comment
There was a problem hiding this comment.
Can you help me understand why you left an empty class for LoggerType here @GeekMasher ?
Contributor
Author
|
@securingdev Absolutely right, it should be an abstract class. Each of the other classes that inherit it will add the "all of the loggers". |
securingdev
approved these changes
Dec 10, 2021
securingdev
approved these changes
Dec 10, 2021
securingdev
approved these changes
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.