Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Conversation

@securingdev
Copy link
Contributor

Need to add testing, but wanted to submit a draft pull request for Go LocalSources support.

@securingdev securingdev changed the title Securingdev go localsources Add LocalSources for Go May 2, 2022
@securingdev
Copy link
Contributor Author

Adds support for #13 requested by @GeekMasher

@GeekMasher
Copy link
Contributor

Awesome work! The only comment I'll make right now is that no query uses this library. We might need to create local variants for these certain queries.

https://github.com/advanced-security/codeql-queries/blob/geekmasher/go-local-variants/go/CWE-078/CodeInjectionLocal.ql

@securingdev
Copy link
Contributor Author

Awesome work! The only comment I'll make right now is that no query uses this library. We might need to create local variants for these certain queries.

https://github.com/advanced-security/codeql-queries/blob/geekmasher/go-local-variants/go/CWE-078/CodeInjectionLocal.ql

That's fair, this PR adds support for our ability to go about doing that - I'll rename the PR accordingly so that there isn't any confusion.

@securingdev securingdev changed the title Add LocalSources for Go Add LocalSources Support for future Go Queries May 3, 2022
@securingdev
Copy link
Contributor Author

In thinking a bit more about this, I may pair down the LocalSources.ql because it feels like some of these should be labeled as "Sinks" instead of sources. Would you agree @GeekMasher?

@GeekMasher GeekMasher added the go label Jul 27, 2022
@GeekMasher GeekMasher marked this pull request as ready for review July 27, 2022 18:32
@GeekMasher GeekMasher self-requested a review as a code owner July 27, 2022 18:32
Copy link
Contributor

@GeekMasher GeekMasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@GeekMasher GeekMasher merged commit fa3e2de into main Jul 27, 2022
@securingdev securingdev deleted the securingdev-go-localsources branch August 11, 2023 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants