Local Sources test cases and False Positives with tempfile

.gitignore

@@ -5,6 +5,8 @@
 # CodeQL related
 .codeql
 .cache
+*.testproj/
+*.actual
 
 # Test files / folders
 test.ql

.vimignore

@@ -0,0 +1,5 @@
+
+codeql/
+codeql-go/
+.cache/
+

python/github/LocalSources.qll

@@ -80,20 +80,16 @@ module LocalSources {
   class FileReadSource extends LocalSources::Range {
     FileReadSource() {
       // exists(StrConst literal | this = DataFlow::exprNode(literal))
-      (
-        exists(DataFlow::Node call |
-          (
-            // https://docs.python.org/3/library/functions.html#open
-            // var = open('abc.txt')
-            call = API::builtin("open").getACall().getAMethodCall("read")
-            or
-            // https://docs.python.org/3/library/os.html#os.read
-            call = API::moduleImport("os").getMember(["read"]).getACall()
-          ) and
-          this = call
-        )
-        or
-        this instanceof FileSystemAccess::Range
+      exists(DataFlow::Node call |
+        (
+          // https://docs.python.org/3/library/functions.html#open
+          // var = open('abc.txt')
+          call = API::builtin("open").getACall().getAMethodCall("read")
+          or
+          // https://docs.python.org/3/library/os.html#os.read
+          call = API::moduleImport("os").getMember(["read"]).getACall()
+        ) and
+        this = call
       ) and
       this.getScope().inSource()
     }

tests/python-tests/libraries/localsources/LocalSourcesTest.expected

@@ -6,9 +6,6 @@
 | app.py:20:8:20:26 | ControlFlowNode for Attribute() |
 | app.py:22:6:22:11 | ControlFlowNode for Attribute |
 | app.py:23:6:23:15 | ControlFlowNode for Attribute |
-| app.py:26:5:26:23 | ControlFlowNode for open() |
 | app.py:27:6:27:13 | ControlFlowNode for Attribute() |
-| app.py:29:6:29:24 | ControlFlowNode for open() |
 | app.py:30:10:30:17 | ControlFlowNode for Attribute() |
-| app.py:32:6:32:40 | ControlFlowNode for Attribute() |
 | app.py:33:7:33:23 | ControlFlowNode for Attribute() |

tests/python-tests/libraries/localsources/app.py

@@ -31,3 +31,11 @@
 
 f2 = os.open("/etc/passwd", os.O_RDONLY)
 i10 = os.read(f2, 1024)
+
+
+# False Positives
+
+import tempfile
+
+t1 = tempfile.gettempdir()
+t2 = tempfile.mkdtemp()