This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Update all queries to use new APIs #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbazztian
reviewed
Sep 19, 2022
zbazztian
reviewed
Sep 19, 2022
Contributor
|
I read through some of the deprecated CodeQL library code and your changes look sensible to me. I did not actually run your code though. Did you test this on some Python code? |
Contributor
Author
|
@zbazztian Can you re-review these and let me know if there is anything else to do |
zbazztian
reviewed
Sep 22, 2022
zbazztian
reviewed
Sep 22, 2022
tests/python-tests/CWE-078/local/CommandInjectionLocal.expected
Outdated
Show resolved
Hide resolved
Contributor
|
Left two comments. |
zbazztian
reviewed
Sep 23, 2022
Contributor
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are failing due to APIs being updated and deprecated