Introduce valuesFiles for various Cilium configurations #322
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WalkthroughThe changes involve significant modifications to the Cilium configuration files across multiple components in a Kubernetes environment. Key alterations include the removal of various parameters related to BPF, cgroup settings, and CNI configurations, indicating a shift towards a simplified configuration approach. New YAML files for specific configurations have been introduced, enhancing modularity and flexibility in managing deployment settings. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Helm
participant Kubernetes
User->>Helm: Deploy Cilium with new values files
Helm->>Kubernetes: Apply configurations from values files
Kubernetes->>Helm: Return deployment status
Helm->>User: Notify deployment success
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- packages/apps/kubernetes/templates/helmreleases/cilium.yaml (1 hunks)
- packages/core/platform/bundles/distro-full.yaml (1 hunks)
- packages/core/platform/bundles/paas-full.yaml (1 hunks)
- packages/core/platform/templates/helmreleases.yaml (1 hunks)
- packages/system/cilium/values-kubeovn.yaml (1 hunks)
- packages/system/cilium/values-talos.yaml (1 hunks)
- packages/system/cilium/values.yaml (1 hunks)
- scripts/package.mk (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/system/cilium/values-talos.yaml
Additional comments not posted (7)
packages/system/cilium/values.yaml (1)
1-12: Review of Cilium Configuration SimplificationThe remaining configurations for
hubble,externalIPs,loadBalancer,ipam,image, andenvoyappear correctly set. However, the significant removal of various settings warrants a thorough verification to ensure that these changes do not negatively impact the deployment or functionality of Cilium within Kubernetes environments.The code changes are approved.
Please ensure to test the impact of these configuration removals on the system's operation.
packages/system/cilium/values-kubeovn.yaml (1)
1-19: Review of New Cilium Configurations for Kube-OVNThe configurations introduced in this file are tailored for Cilium's integration with Kube-OVN. It's crucial to ensure that these settings are correctly implemented and do not conflict with other configurations within the system.
The code changes are approved.
Please verify the integration of these settings with the overall system to ensure there are no conflicts or issues.
packages/apps/kubernetes/templates/helmreleases/cilium.yaml (1)
Line range hint
1-36: Review of HelmRelease Configuration Simplification for CiliumThe remaining configurations under
valuesfortunnel,k8sServiceHost,k8sServicePort,routingMode,enableIPv4Masquerade, andipv4NativeRoutingCIDRappear correctly set. However, the significant removal of various settings warrants a thorough verification to ensure that these changes do not negatively impact the deployment or functionality of Cilium within Kubernetes environments.The code changes are approved.
Please ensure to test the impact of these configuration removals on the system's operation.
packages/core/platform/templates/helmreleases.yaml (1)
42-45: Review of the newvaluesFilesconditional block.The addition of the
valuesFilesblock using thewithdirective is correctly implemented. The use oftoYamlfor formatting andnindentfor indentation appears to be correctly applied. This enhancement should allow for more flexible Helm chart generation based on additional values files.The code changes are approved.
scripts/package.mk (1)
3-3: Review of the new.VALUES_FILESvariable.The introduction of the
.VALUES_FILESvariable enhances the flexibility of Helm commands by dynamically constructing a list of values files. The shell command used appears to be correctly formatted and should function as intended if the Kubernetes environment is configured correctly.The code changes are approved.
packages/core/platform/bundles/distro-full.yaml (1)
23-25: Review of changes to theciliumrelease configuration.The addition of
valuesFilesentries (values.yamlandvalues-talos.yaml) is correctly implemented and should enhance the modularity of the configuration. The removal of certainciliumparameters (not shown in the provided code) needs to be assessed for impact, but the changes appear to be aimed at simplifying the configuration.The code changes are approved.
packages/core/platform/bundles/paas-full.yaml (1)
23-26: Approved: Addition of valuesFiles for Cilium configurations.The addition of
values.yaml,values-talos.yaml, andvalues-kubeovn.yamlto thevaluesFilessection under theciliumrelease is correctly implemented and aligns with the PR objectives to enhance configuration management. The syntax is correct, and the files are appropriately listed to allow for modular configuration management.
This PR fixes regression introduced by #322 Tenant clusters have `kubeProxyReplacement` disabled, must be enabled
This PR introduces different values files for
cozy-ciliumchart, andvaluesFilesfor fluxcd.This might be useful in cases where same chart reused for multiple configurations
Summary by CodeRabbit
New Features
Bug Fixes
Documentation